Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KVS Cleanup #1073

Merged
merged 4 commits into from May 20, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented May 20, 2017

A few cleanups spliced out of PR #1066

chu11 added some commits May 17, 2017

modules/kvs: Cleanup load() function
Remove confusing logic behind stall variable.
modules/kvs: Code cleanup in walk()
Cleanup code, clearly separating error checks from primary
read/loading logic.

@chu11 chu11 force-pushed the chu11:kvsrefactor7-cleanup branch from b294fd6 to 116502f May 20, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 20, 2017

Coverage Status

Coverage increased (+0.01%) to 78.055% when pulling 116502f on chu11:kvsrefactor7-cleanup into dc46d77 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 20, 2017

Codecov Report

Merging #1073 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1073      +/-   ##
=========================================
+ Coverage   77.79%   77.8%   +0.01%     
=========================================
  Files         148     148              
  Lines       25766   25764       -2     
=========================================
+ Hits        20044   20046       +2     
+ Misses       5722    5718       -4
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 80.64% <100%> (+0.19%) ⬆️
src/common/libflux/message.c 81.45% <0%> (-0.36%) ⬇️
src/common/libflux/handle.c 84.41% <0%> (-0.29%) ⬇️
src/modules/kvs/libkvs.c 75.49% <0%> (+0.11%) ⬆️
src/common/libflux/dispatch.c 83.51% <0%> (+0.27%) ⬆️
src/common/libutil/dirwalk.c 94.07% <0%> (+0.74%) ⬆️
src/common/libflux/rpc.c 92% <0%> (+1.09%) ⬆️
@coveralls

This comment has been minimized.

Copy link

coveralls commented May 20, 2017

Coverage Status

Coverage increased (+0.01%) to 78.055% when pulling 116502f on chu11:kvsrefactor7-cleanup into dc46d77 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented May 20, 2017

LGTM. Ready to merge?

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented May 20, 2017

yup, these are just simple ones

@garlick garlick merged commit 32268ce into flux-framework:master May 20, 2017

4 checks passed

codecov/patch 100% of diff hit (target 77.79%)
Details
codecov/project 77.8% (+0.01%) compared to dc46d77
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 78.055%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.