Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
split flux_mrpc() out to its own class #1080
While designing futures (#1053), it seemed obvious that
Therefore, to allow
There is some code duplication, but now there is a separation of concerns, and the heavily used
Users, tests, and man pages are updated to reflect this change.
@@ Coverage Diff @@ ## master #1080 +/- ## ========================================== - Coverage 77.98% 77.95% -0.03% ========================================== Files 150 151 +1 Lines 25963 26109 +146 ========================================== + Hits 20246 20353 +107 - Misses 5717 5756 +39
I guess there are two optimizations
So if you did say 1000 separate
I'm not necessarily defending flux_mrpc_t as useful or interesting. Probably it needs to get reworked another way someday, for example using event (broadcast) for the request, and reduction for the responses. For now it gets the job done I guess.