Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reactor documentation #1086

Merged
merged 2 commits into from Jun 7, 2017

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Jun 7, 2017

Fix a comment in reactor.h for FLUX_REACTOR_NOWAIT that was out of date, as noted by @grondo in #1085.

Also, fix an out of date flag description in flux_reactor_create(3).

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage decreased (-0.004%) to 78.146% when pulling 5f440ab on garlick:reactor_run into 8bd3860 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 7, 2017

Codecov Report

Merging #1086 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   77.89%   77.89%   -0.01%     
==========================================
  Files         150      150              
  Lines       25930    25930              
==========================================
- Hits        20199    20198       -1     
- Misses       5731     5732       +1
Impacted Files Coverage Δ
src/common/libflux/handle.c 84.81% <0%> (-0.29%) ⬇️
src/modules/kvs/kvs.c 79.53% <0%> (-0.26%) ⬇️
src/modules/connector-local/local.c 70.28% <0%> (-0.21%) ⬇️
src/common/libflux/message.c 81.33% <0%> (-0.12%) ⬇️
src/common/libutil/veb.c 98.87% <0%> (+0.56%) ⬆️
src/common/libutil/dirwalk.c 94.81% <0%> (+0.74%) ⬆️
src/cmd/flux-event.c 66.66% <0%> (+1.11%) ⬆️
src/common/libflux/request.c 90.41% <0%> (+1.36%) ⬆️

@grondo grondo merged commit 405927b into flux-framework:master Jun 7, 2017

3 of 4 checks passed

codecov/project 77.89% (-0.01%) compared to 8bd3860
Details
codecov/patch Coverage not affected when comparing 8bd3860...5f440ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 78.146%
Details
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jun 7, 2017

Merging thanks!

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

@garlick garlick deleted the garlick:reactor_run branch Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.