Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor test improvements #1087

Merged
merged 5 commits into from Jun 7, 2017

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Jun 7, 2017

These are some assorted test improvements split out of PR #1083

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage decreased (-0.03%) to 78.135% when pulling f027a9b on garlick:minor_test_improvements into 405927b on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 7, 2017

Codecov Report

Merging #1087 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
- Coverage   77.91%   77.87%   -0.04%     
==========================================
  Files         150      150              
  Lines       25930    25930              
==========================================
- Hits        20203    20194       -9     
- Misses       5727     5736       +9
Impacted Files Coverage Δ
src/common/libflux/request.c 89.04% <0%> (-1.37%) ⬇️
src/common/libflux/tagpool.c 95.12% <0%> (-1.22%) ⬇️
src/broker/modservice.c 79.2% <0%> (-1%) ⬇️
src/common/libutil/dirwalk.c 93.33% <0%> (-0.75%) ⬇️
src/common/libflux/rpc.c 91.22% <0%> (-0.59%) ⬇️
src/common/libflux/message.c 81.56% <0%> (-0.36%) ⬇️
src/common/libflux/handle.c 85.1% <0%> (-0.29%) ⬇️
src/modules/connector-local/local.c 70.28% <0%> (-0.21%) ⬇️
src/cmd/flux-event.c 66.66% <0%> (+1.11%) ⬆️
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jun 7, 2017

Does this need rebase?

garlick added some commits May 31, 2017

t/rpc: drop test for NULL continuation callback
This behavior is unnecessary and is not implemented in
future-based RPC.
t/rpc: drop extra flux_close()
The destructor for the fake service is tied to a close
of the client flux handle, therefore don't try to close
the client handle in the destructor.
t/t0001-basic.t: use flux exec not wreckrun
Use flux-exec not flux-wreckrun for testing, especially
in early basic test.
test/valgrind: extend shutdown-grace to 4s
Problem: valgrind test intermittently fails in travis, due to
modules failing to unload during the shutdown grace period.
Since things run much slower under valgrind, this grace
period likely needs to be bumped up from the default of 1s.

Try 4s.

Example falure:

lt-flux-broker: module 'content-sqlite' was not cleanly shutdown
==24877==
==24877== HEAP SUMMARY:
==24877==     in use at exit: 118,379 bytes in 172 blocks
==24877==   total heap usage: 591,670 allocs, 591,498 frees, 61,206,388
bytes allocated
==24877==
==24877== 8 bytes in 1 blocks are definitely lost in loss record 6 of 83
==24877==    at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==24877==    by 0x41B225: xzmalloc (xzmalloc.c:39)
==24877==    by 0x40B41F: module_thread (module.c:156)
==24877==    by 0x57B1E99: start_thread (pthread_create.c:308)
==24877==    by 0x5EC92EC: clone (clone.S:112)
==24877== 43 bytes in 2 blocks are definitely lost in loss record 31 of 83
==24877==    at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==24877==    by 0x5EDF807: __vasprintf_chk (vasprintf_chk.c:82)
==24877==    by 0x41B348: xvasprintf (stdio2.h:199)
==24877==    by 0x41B42B: xasprintf (xzmalloc.c:78)
==24877==    by 0x40B367: module_thread (module.c:125)
==24877==    by 0x57B1E99: start_thread (pthread_create.c:308)
==24877==    by 0x5EC92EC: clone (clone.S:112)
==24877==
==24877== LEAK SUMMARY:
==24877==    definitely lost: 51 bytes in 3 blocks
==24877==    indirectly lost: 0 bytes in 0 blocks
==24877==      possibly lost: 0 bytes in 0 blocks
==24877==    still reachable: 117,816 bytes in 168 blocks
==24877==         suppressed: 512 bytes in 1 blocks
==24877== Reachable blocks (those to which a pointer was found) are not shown.
==24877== To see them, rerun with: --leak-check=full --show-reachable=yes
==24877==
==24877== For counts of detected and suppressed errors, rerun with: -v
==24877== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 53 from
14)
not ok 1 - valgrind reports no new errors on single broker run

@garlick garlick force-pushed the garlick:minor_test_improvements branch from f027a9b to 82eed5a Jun 7, 2017

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jun 7, 2017

Oops yes, just pushed one.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 7, 2017

Coverage Status

Coverage decreased (-0.03%) to 78.131% when pulling 82eed5a on garlick:minor_test_improvements into 405927b on flux-framework:master.

@grondo grondo merged commit 33589c6 into flux-framework:master Jun 7, 2017

3 of 4 checks passed

codecov/project 77.87% (-0.04%) compared to 405927b
Details
codecov/patch Coverage not affected when comparing 405927b...82eed5a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 78.131%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

@garlick garlick deleted the garlick:minor_test_improvements branch Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.