Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FLUX_PMI_SINGLETON env variable to avoid SLURM's libpmi in valgrind test #1091

Merged
merged 1 commit into from Jun 14, 2017

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Jun 13, 2017

Problem: Valgrind test reports leaks in slurm's libpmi.so
on TOSS 2 systems.

The broker, or rather our internal PMI library, will try
hard to use an external PMI environment if available.
On systems where slurm's libpmi.so is installed, the
broker, when run without flux-start, will use that, and
our valgrind test reports leaks in it.

Add environment variable FLUX_PMI_SINGLETON which can be used
to force (internal) singleton bootstrap if no other
environment variables are set to influence PMI bootstrap.

Fixes #1090

test/valgrind: avoid finding bugs in slurm libpmi
Problem: Valgrind test reports leaks in slurm's libpmi.so
on TOSS 2 systems.

The broker, or rather our internal PMI library, will try
hard to use an external PMI environment if available.
On systems where slurm's libpmi.so is installed, the
broker, when run without flux-start, will use that, and
our valgrind test reports leaks in it.

Add environment variable FLUX_PMI_SINGLETON which can be used
to force (internal) singleton bootstrap if no other
environment variables are set to influence PMI bootstrap.

Fixes #1090
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jun 13, 2017

Cool, works for me on the failing system. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 13, 2017

Codecov Report

Merging #1091 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
+ Coverage   77.98%   78.03%   +0.05%     
==========================================
  Files         151      151              
  Lines       26105    26105              
==========================================
+ Hits        20357    20371      +14     
+ Misses       5748     5734      -14
Impacted Files Coverage Δ
src/common/libpmi/pmi.c 47.03% <100%> (ø) ⬆️
src/common/libflux/mrpc.c 85.31% <0%> (-1.2%) ⬇️
src/common/libflux/message.c 81.33% <0%> (-0.12%) ⬇️
src/common/libflux/handle.c 85.75% <0%> (ø) ⬆️
src/common/libflux/reactor.c 93.39% <0%> (+0.28%) ⬆️
src/connectors/local/local.c 87.59% <0%> (+0.77%) ⬆️
src/broker/modservice.c 80.19% <0%> (+0.99%) ⬆️
src/broker/module.c 83.66% <0%> (+1.12%) ⬆️
src/common/libflux/dispatch.c 86.32% <0%> (+1.17%) ⬆️
src/broker/content-cache.c 74.29% <0%> (+1.3%) ⬆️
... and 2 more
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 13, 2017

Coverage Status

Coverage increased (+0.05%) to 78.293% when pulling 7a9c8d7 on garlick:pmi_valgrind_fix into 609d88f on flux-framework:master.

@grondo grondo merged commit b306196 into flux-framework:master Jun 14, 2017

4 checks passed

codecov/patch 100% of diff hit (target 77.98%)
Details
codecov/project 78.03% (+0.05%) compared to 609d88f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 78.293%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

@garlick garlick deleted the garlick:pmi_valgrind_fix branch Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.