Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run valgrind tests if valgrind/valgrind.h was found #1098

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Jun 28, 2017

Quick attempt at w/a for false positive valgrind results observed in #1097.

Even if valgrind/valgrind.h is not found, the test can be forced if the -d or --debug option is used on the cmdline, e.g.:

 grondo@hype2:~/git/flux-core.git/t$ ./t5000-valgrind.t 
1..0 # SKIP skipping valgrind tests b/c valgrind.h not found. Use -d, --debug to force
 grondo@hype2:~/git/flux-core.git/t$ ./t5000-valgrind.t -d    
sharness: loading extensions from /g/g0/grondo/git/flux-core.git/t/sharness.d/01-setup.sh
sharness: loading extensions from /g/g0/grondo/git/flux-core.git/t/sharness.d/flux-sharness.sh
not ok 1 - valgrind reports no new errors on single broker run
#	
#		flux ${VALGRIND} \
#			--tool=memcheck \
#			--leak-check=full \
#			--gen-suppressions=all \
#			--trace-children=no \
#			--child-silent-after-fork=yes \
#			--num-callers=30 \
#			--leak-resolution=med \
#			--error-exitcode=1 \
#			--suppressions=$VALGRIND_SUPPRESSIONS \
#			${BROKER} --shutdown-grace=4 ${VALGRIND_WORKLOAD} 10
#	
# failed 1 among 1 test(s)
1..1

t/t5000-valgrind.t: disable unless valgrind.h found
Disable t5000-valgrind.t by default when valgrind/valgrind.h was
not found by ./configure. This means that the valgrind hook to
disable dlclose() for modules is not active, and this has been found
to cause false positives for this test.

The test can still be forced by hand with the use of -d, --debug flag,
e.g.

 ./t5000-valgrind.t -d

Fixes #1097
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 28, 2017

Coverage Status

Coverage increased (+0.09%) to 78.301% when pulling 6c555ee on grondo:issue#1097 into 48408d5 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jun 28, 2017

Looks good, thanks for doing that.

@garlick garlick merged commit f52272c into flux-framework:master Jun 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 78.301%
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 29, 2017

Codecov Report

Merging #1098 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
+ Coverage   77.95%   78.04%   +0.09%     
==========================================
  Files         151      151              
  Lines       26115    26115              
==========================================
+ Hits        20357    20381      +24     
+ Misses       5758     5734      -24
Impacted Files Coverage Δ
src/common/libflux/response.c 83.76% <0%> (-0.86%) ⬇️
src/common/libflux/future.c 87.16% <0%> (-0.54%) ⬇️
src/common/libflux/handle.c 86.01% <0%> (-0.52%) ⬇️
src/common/libkvs/kvs.c 75.49% <0%> (+0.11%) ⬆️
src/common/libflux/message.c 81.8% <0%> (+0.23%) ⬆️
src/common/libflux/reactor.c 93.39% <0%> (+0.28%) ⬆️
src/broker/overlay.c 72.02% <0%> (+0.34%) ⬆️
src/modules/kvs/kvs.c 79.79% <0%> (+0.38%) ⬆️
src/connectors/local/local.c 87.59% <0%> (+0.77%) ⬆️
src/common/libflux/dispatch.c 86.32% <0%> (+0.78%) ⬆️
... and 5 more

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

@grondo grondo deleted the grondo:issue#1097 branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.