Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
clean up KVS API implementation #1099
This PR divides up the KVS API into separate source files, reimplements some parts in terms of jansson, addresses some exit-on-malloc-failure behavior, and takes a small step towards the API changes proposed in #1094, implementing these lookup functions:
flux_future_t *flux_kvs_lookup (flux_t *h, int flags, const char *key); flux_future_t *flux_kvs_lookupat (flux_t *h, int flags, const char *key, const char *treeobj); int flux_kvs_lookup_get (flux_future_t *f, const char **json_str); int flux_kvs_lookup_getf (flux_future_t *f, const char *fmt, ...);
Apart from those new functions, this is mostly cleanup. #1094 goes much further in its proposed changes, but I don't think that design has settled yet, and this PR is big enough it should probably stand alone.
Still todo: man pages for the above functions.
@@ Coverage Diff @@ ## master #1099 +/- ## ========================================= + Coverage 78.04% 78.3% +0.26% ========================================= Files 151 156 +5 Lines 26115 26084 -31 ========================================= + Hits 20381 20426 +45 + Misses 5734 5658 -76
It appears from coverage that some of the kvs_watch functions aren't covered. For the deprecated functions, I wonder if this would be a good point to excise unused code (e.g.
Other untested interfaces appear to include