Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
reduce legacy KVS API #1100
@@ Coverage Diff @@ ## master #1100 +/- ## ========================================== - Coverage 78.19% 78.13% -0.07% ========================================== Files 156 155 -1 Lines 26084 25959 -125 ========================================== - Hits 20397 20282 -115 + Misses 5687 5677 -10
I think it would be OK to merge. I didn't look too closely at the coverage. The KVS API was well covered and this removes a chunk of it, so I could see overall project coverage dropping a bit. The lookup API replaces one call with two thus there are more error paths that are probably not checked.