Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce legacy KVS API #1100

Merged
merged 19 commits into from Jul 7, 2017

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Jul 7, 2017

This PR finally gets rid of the json-c based KVS API functions that were marked deprecated, and removes a lot of the older "get" functions, updating users to flux_kvs_lookup(). It also adds a man page for flux_kvs_lookup().

garlick added some commits Jul 4, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 7, 2017

Coverage Status

Coverage decreased (-0.06%) to 78.389% when pulling 8e622a6 on garlick:kvs_lookup_doc into f2cf6be on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 7, 2017

Codecov Report

Merging #1100 into master will decrease coverage by 0.06%.
The diff coverage is 64.96%.

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
- Coverage   78.19%   78.13%   -0.07%     
==========================================
  Files         156      155       -1     
  Lines       26084    25959     -125     
==========================================
- Hits        20397    20282     -115     
+ Misses       5687     5677      -10
Impacted Files Coverage Δ
src/common/libkvs/kvs_classic.c 87.87% <ø> (-1.27%) ⬇️
src/bindings/lua/flux-lua.c 81.61% <100%> (-0.06%) ⬇️
src/bindings/lua/kvs-lua.c 76.59% <57.14%> (-0.71%) ⬇️
src/common/libjsc/jstatctl.c 78.18% <60.71%> (-0.38%) ⬇️
src/cmd/flux-kvs.c 77.03% <62.5%> (-0.03%) ⬇️
src/bindings/lua/json-lua.c 82.45% <63.15%> (-3.86%) ⬇️
src/modules/wreck/wrexecd.c 75.37% <65.78%> (-0.31%) ⬇️
src/modules/resource-hwloc/resource.c 70.58% <68%> (-0.75%) ⬇️
src/common/libflux/request.c 89.04% <0%> (-1.37%) ⬇️
src/common/libflux/response.c 83.76% <0%> (-0.86%) ⬇️
... and 8 more

@garlick garlick force-pushed the garlick:kvs_lookup_doc branch from 8e622a6 to 485996b Jul 7, 2017

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jul 7, 2017

Just fixed a commit message and forced a push. I should have added that I'm pretty sure none of the KVS interfaces used by sched were altered here (based on examining source, not an actual test).

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 7, 2017

Coverage Status

Coverage decreased (-0.06%) to 78.389% when pulling 485996b on garlick:kvs_lookup_doc into f2cf6be on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jul 7, 2017

Nice. sorry about all the work required in the outdated lua bindings.

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jul 7, 2017

No worries on the lua stuff. BTW I'm done here and hitting the road. My intent is to continue in another PR with a cleanup of the kvsdir_t stuff and expanded docs.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jul 7, 2017

Ok, so this is ready for merge? I'm kind of confused by the coverage drop but nothing looks too out of the ordinary at this point.

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Jul 7, 2017

I think it would be OK to merge. I didn't look too closely at the coverage. The KVS API was well covered and this removes a chunk of it, so I could see overall project coverage dropping a bit. The lookup API replaces one call with two thus there are more error paths that are probably not checked.

@grondo grondo merged commit 041cf5f into flux-framework:master Jul 7, 2017

2 of 4 checks passed

codecov/patch 64.96% of diff hit (target 78.19%)
Details
codecov/project 78.13% (-0.07%) compared to f2cf6be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 78.389%
Details

@garlick garlick deleted the garlick:kvs_lookup_doc branch Jul 8, 2017

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.