Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent failure of t2000-wreck.t #1102

Merged
merged 1 commit into from Jul 8, 2017

Conversation

Projects
None yet
5 participants
@grondo
Copy link
Contributor

grondo commented Jul 7, 2017

Fix failure:

not ok 49 - wreck job is linked in lwj-complete after failure

which may occur if lwj-complete. directory has not appeared
in kvs by the time of the first pass in the check_complete_link()
function.

Instead of checking for the last epoch dir once in the function,
check it on every loop.

Fixes #1101

t2000-wreck.t: fix check for archived jobs
Fix failure

 not ok 49 - wreck job is linked in lwj-complete after failure

which may occur if lwj-complete.<epoch> directory has not appeared
in kvs by the time of the *first* pass in the check_complete_link()
function.

Instead of checking for the last epoch dir once in the function,
check it on every loop.

Fixes #1101
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jul 7, 2017

Looks reasonable, thanks @grondo! Should I go ahead and merge or should we wait for confirmation from @lipari that it fixes it for him?

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jul 8, 2017

The caliper build got stuck here so I restarted it

PASS: t0016-cron-faketime.t 2 - load cron module
PASS: t0016-cron-faketime.t 3 - flux-cron tab works for set minute
FAIL: t0016-cron-faketime.t 4 - flux-cron tab works for any day midnight
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 8, 2017

Coverage Status

Coverage decreased (-0.004%) to 78.389% when pulling 47e982d on grondo:issue#1101 into 041cf5f on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 8, 2017

Codecov Report

Merging #1102 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
- Coverage   78.13%   78.13%   -0.01%     
==========================================
  Files         155      155              
  Lines       25959    25959              
==========================================
- Hits        20283    20282       -1     
- Misses       5676     5677       +1
Impacted Files Coverage Δ
src/common/libflux/dispatch.c 85.15% <0%> (-0.4%) ⬇️
src/common/libflux/handle.c 85.49% <0%> (-0.26%) ⬇️
src/modules/kvs/kvs.c 79.56% <0%> (-0.26%) ⬇️
src/common/libflux/message.c 81.68% <0%> (+0.23%) ⬆️
src/common/libflux/future.c 87.7% <0%> (+0.53%) ⬆️
@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jul 8, 2017

Probably wait for @lipari. Though once I added any changes to this area of the test the failure became more difficult to reproduce.

@lipari lipari merged commit 062ade5 into flux-framework:master Jul 8, 2017

3 of 4 checks passed

codecov/project 78.13% (-0.01%) compared to 041cf5f
Details
codecov/patch Coverage not affected when comparing 041cf5f...47e982d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 78.389%
Details
@lipari

This comment has been minimized.

Copy link
Contributor

lipari commented Jul 8, 2017

Fixes #1101

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jul 8, 2017

Thanks @lipari!

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

@grondo grondo deleted the grondo:issue#1101 branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.