Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/kvs: Add json_util unit tests #1106

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Jul 13, 2017

A simple addition. I was playing with converting the fence unit tests to jansson, but those tests use json_compare in json_util, so really need to convert that first. Thus some unit tests were in order.

@chu11 chu11 force-pushed the chu11:json_util_unit_tests branch from faa8ba3 to 4304d84 Jul 13, 2017

@chu11 chu11 force-pushed the chu11:json_util_unit_tests branch from 4304d84 to de02387 Jul 13, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage increased (+0.04%) to 78.542% when pulling de02387 on chu11:json_util_unit_tests into afcbd94 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 13, 2017

Codecov Report

Merging #1106 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
- Coverage   78.23%   78.22%   -0.02%     
==========================================
  Files         157      157              
  Lines       26132    26132              
==========================================
- Hits        20445    20442       -3     
- Misses       5687     5690       +3
Impacted Files Coverage Δ
src/common/libflux/mrpc.c 85.31% <0%> (-1.2%) ⬇️
src/cmd/flux-event.c 65.55% <0%> (-1.12%) ⬇️
src/common/libutil/dirwalk.c 93.33% <0%> (-0.75%) ⬇️
src/common/libutil/veb.c 98.31% <0%> (-0.57%) ⬇️
src/broker/overlay.c 71.32% <0%> (-0.35%) ⬇️
src/common/libflux/message.c 81.21% <0%> (-0.12%) ⬇️
src/bindings/lua/flux-lua.c 81.61% <0%> (-0.1%) ⬇️
src/modules/connector-local/local.c 70.26% <0%> (+0.2%) ⬆️
src/common/libflux/dispatch.c 85.54% <0%> (+0.39%) ⬆️
src/modules/kvs/kvs.c 79.43% <0%> (+0.47%) ⬆️
... and 1 more
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage increased (+0.04%) to 78.542% when pulling de02387 on chu11:json_util_unit_tests into afcbd94 on flux-framework:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage decreased (-0.01%) to 78.486% when pulling de02387 on chu11:json_util_unit_tests into afcbd94 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jul 13, 2017

Great!

@garlick garlick merged commit 03ace30 into flux-framework:master Jul 13, 2017

3 of 4 checks passed

codecov/project 78.22% (-0.02%) compared to afcbd94
Details
codecov/patch Coverage not affected when comparing afcbd94...de02387
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 78.486%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.