Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: make bindings compatible with newer versions of pylint #1113

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
5 participants
@SteVwonder
Copy link
Member

SteVwonder commented Jul 20, 2017

remove the deprecated unused-argument:

  • remove the unused argument in kvs walk
  • rename then_wrapper to cb_then_wrapper; pylint won't check
    functions prefixed with cb_ for unused arguments

remove the deprecated required-attributes and ignore-iface-methods
swap the deprecated ignore-all for skip-file

Related: #1046 (I don't believe this fully fixes it, but it addresses several of the issues)

@SteVwonder SteVwonder requested a review from trws Jul 20, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 20, 2017

Coverage Status

Coverage increased (+0.02%) to 78.32% when pulling b865820 on SteVwonder:pylint into 500e366 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 20, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@fced5eb). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1113   +/-   ##
=========================================
  Coverage          ?   77.98%           
=========================================
  Files             ?      157           
  Lines             ?    25988           
  Branches          ?        0           
=========================================
  Hits              ?    20268           
  Misses            ?     5720           
  Partials          ?        0
@trws

trws approved these changes Jul 21, 2017

Copy link
Member

trws left a comment

I approve of this update, and it seems travis is good to go based on it passing in this PR.

@trws

This comment has been minimized.

Copy link
Member

trws commented Jul 21, 2017

Given a rebase, I would say LGTM.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jul 21, 2017

Thanks @SteVwonder!

python: make bindings compatible with newer versions of pylint
remove the deprecated `unused-argument`:
  - remove the unused argument in kvs walk
  - rename `then_wrapper` to `cb_then_wrapper`, pylint won't check
    functions prefixed with `cb_` for unused arguments
remove the deprecated `required-attributes,ignore-iface-methods`
swap the deprecated `ignore-all` for `skip-file`

@SteVwonder SteVwonder force-pushed the SteVwonder:pylint branch from b865820 to 0793b5b Jul 21, 2017

@SteVwonder

This comment has been minimized.

Copy link
Member Author

SteVwonder commented Jul 21, 2017

Rebase done

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 21, 2017

Coverage Status

Changes Unknown when pulling 0793b5b on SteVwonder:pylint into ** on flux-framework:master**.

@grondo grondo merged commit 1e1480f into flux-framework:master Jul 21, 2017

3 of 4 checks passed

codecov/project No report found to compare against
Details
codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 78.256%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

@SteVwonder SteVwonder deleted the SteVwonder:pylint branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.