Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs_classic: fix kvs(dir)_put_double #1114

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
4 participants
@SteVwonder
Copy link
Member

SteVwonder commented Jul 20, 2017

jansson format string for packing a double is "f" as opposed to "F"

Partial fix to flux-framework/flux-sched#256

kvs_classic: fix kvs(dir)_put_double
jansson format string for double is "f" as opposed to "F"

@SteVwonder SteVwonder requested a review from garlick Jul 20, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 20, 2017

Coverage Status

Coverage increased (+0.007%) to 78.309% when pulling 459e247 on SteVwonder:kvs-classic-fix into 500e366 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 20, 2017

Codecov Report

Merging #1114 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
+ Coverage   78.03%   78.04%   +<.01%     
==========================================
  Files         159      159              
  Lines       26232    26232              
==========================================
+ Hits        20470    20472       +2     
+ Misses       5762     5760       -2
Impacted Files Coverage Δ
src/common/libkvs/kvs_classic.c 84.54% <0%> (ø) ⬆️
src/common/libkvs/kvs_watch.c 86.76% <0%> (-0.99%) ⬇️
src/common/libflux/dispatch.c 85.93% <0%> (-0.4%) ⬇️
src/common/libflux/message.c 81.56% <0%> (+0.23%) ⬆️
src/common/libflux/handle.c 83.67% <0%> (+0.25%) ⬆️
src/common/libflux/future.c 87.7% <0%> (+0.53%) ⬆️
src/common/libflux/response.c 84.61% <0%> (+0.85%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jul 20, 2017

Ah my bad! Thanks, this looks right. F is for unpack only, f is for pack.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jul 20, 2017

@garlick garlick merged commit 3bd59f3 into flux-framework:master Jul 20, 2017

3 of 4 checks passed

codecov/patch 0% of diff hit (target 78.03%)
Details
codecov/project 78.04% (+<.01%) compared to 500e366
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 78.309%
Details

@grondo grondo referenced this pull request Aug 23, 2017

Closed

0.8.0 Release #1160

@SteVwonder SteVwonder deleted the SteVwonder:kvs-classic-fix branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.