Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libflux: Add input checks to future functions #1166

Merged
merged 5 commits into from Aug 29, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Aug 28, 2017

Add missing input checks to various future functions and add appropriate unit tests.
Add missing unit tests in libkvs, as that was what prompted issue #1157.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage increased (+0.06%) to 78.118% when pulling 49a6437 on chu11:issue1157 into 1c99b02 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #1166 into master will increase coverage by <.01%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
+ Coverage   77.67%   77.67%   +<.01%     
==========================================
  Files         158      158              
  Lines       29040    29087      +47     
==========================================
+ Hits        22556    22594      +38     
- Misses       6484     6493       +9
Impacted Files Coverage Δ
src/common/libflux/future.c 88.61% <94.11%> (+1.31%) ⬆️
src/cmd/builtin/env.c 94.11% <0%> (-5.89%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-1.71%) ⬇️
src/broker/module.c 83.28% <0%> (-1.68%) ⬇️
src/broker/content-cache.c 73.27% <0%> (-1.3%) ⬇️
src/common/libflux/request.c 88.46% <0%> (-1.29%) ⬇️
src/common/libflux/mrpc.c 85.15% <0%> (-1.18%) ⬇️
src/common/libflux/attr.c 87.67% <0%> (-0.92%) ⬇️
src/common/libkvs/kvs_watch.c 86.34% <0%> (-0.89%) ⬇️
src/broker/overlay.c 71.67% <0%> (-0.35%) ⬇️
... and 9 more

chu11 added some commits Aug 28, 2017

libflux/future: Add NULL future input checks
In most of future library, check for corner case where user passes
in NULL flux_future_t pointer.

Fixes #1157
libflux/future/test: Add new tests
Add coverage for future == NULL corner cases tests.
libflux/future: Set errno in flux_future_aux_get
Set errno appropriately when errors occur in flux_future_aux_get().
libflux/future/test: Add flux_future_aux_get tests
Add tests to check for errno return values from flux_future_aux_get().

@chu11 chu11 force-pushed the chu11:issue1157 branch from 49a6437 to 87b5524 Aug 29, 2017

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Aug 29, 2017

rebased

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-0.03%) to 78.028% when pulling 87b5524 on chu11:issue1157 into 820301e on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 29, 2017

Looks straightforward, thank you!

@garlick garlick merged commit a52a9c2 into flux-framework:master Aug 29, 2017

4 checks passed

codecov/patch 94.11% of diff hit (target 77.67%)
Details
codecov/project 77.67% (+<.01%) compared to 820301e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 78.028%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.