Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/libflux: minor flux_msg_handler cleanup/fixes #1171

Merged
merged 2 commits into from Aug 29, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Aug 29, 2017

No description provided.

chu11 added some commits Aug 29, 2017

common/libflux: Rename dispatch.[ch]
Rename dispatch.[ch] to msg_handler.[ch] for clarity.

Fixes #1136
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 29, 2017

One of the travis builds hit #1077, which looks like a racy test. Restarting...

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 29, 2017

Coverage Status

Coverage increased (+0.06%) to 78.094% when pulling 552cab6 on chu11:issue11341136 into 0c87cfa on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 29, 2017

The restart failed with a write error. Restarting...

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 29, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@0c87cfa). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1171   +/-   ##
=========================================
  Coverage          ?   77.72%           
=========================================
  Files             ?      158           
  Lines             ?    29089           
  Branches          ?        0           
=========================================
  Hits              ?    22610           
  Misses            ?     6479           
  Partials          ?        0
Impacted Files Coverage Δ
src/common/libflux/rpc.c 92.56% <ø> (ø)
src/common/libflux/msg_handler.c 84.81% <ø> (ø)
src/common/libflux/handle.c 83.66% <ø> (ø)
src/common/libcompat/reactor.c 77.95% <ø> (ø)
src/common/libflux/mrpc.c 86.32% <ø> (ø)
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 29, 2017

Straightforward. Thanks!

@garlick garlick merged commit 6da40cb into flux-framework:master Aug 29, 2017

3 of 4 checks passed

codecov/project No report found to compare against
Details
codecov/patch Coverage not affected when comparing 0c87cfa...552cab6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 78.094%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.