Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/cron: fix segfault on 32 bit systems #1178

Merged
merged 1 commit into from Sep 1, 2017

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Sep 1, 2017

Problem: cron module segfaults during travis testing on arm7l.

Change a json_pack() format string to use "I" not "i" to
refer to uint64_t values.

Fixes #1176

modules/cron: fix segfault on 32 bit systems
Problem: cron module segfaults during travis testing on arm7l.

Change a json_pack() format string to use "I" not "i" to
refer to uint64_t values.

Fixes #1176
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 1, 2017

Coverage Status

Coverage increased (+0.07%) to 78.206% when pulling 02d6995 on garlick:cron_segfault into 59607e7 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 1, 2017

Codecov Report

Merging #1178 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #1178     +/-   ##
========================================
+ Coverage    77.8%   77.9%   +0.1%     
========================================
  Files         158     158             
  Lines       29209   29210      +1     
========================================
+ Hits        22725   22757     +32     
+ Misses       6484    6453     -31
Impacted Files Coverage Δ
src/modules/cron/cron.c 79.48% <100%> (ø) ⬆️
src/broker/module.c 83.28% <0%> (-0.28%) ⬇️
src/common/libflux/message.c 81.29% <0%> (+0.23%) ⬆️
src/common/libflux/future.c 89.6% <0%> (+0.49%) ⬆️
src/common/libkvs/kvs.c 65.8% <0%> (+0.51%) ⬆️
src/modules/kvs/kvs.c 63.88% <0%> (+0.53%) ⬆️
src/common/libkvs/kvs_watch.c 87.22% <0%> (+0.88%) ⬆️
src/common/libflux/request.c 88.46% <0%> (+1.28%) ⬆️
src/common/libcompat/handle.c 87.08% <0%> (+1.91%) ⬆️
src/common/libflux/handle.c 86.13% <0%> (+2.22%) ⬆️
... and 1 more

@grondo grondo merged commit 9dcd16a into flux-framework:master Sep 1, 2017

4 checks passed

codecov/patch 100% of diff hit (target 77.8%)
Details
codecov/project 77.9% (+0.1%) compared to 59607e7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 78.206%
Details

@garlick garlick deleted the garlick:cron_segfault branch Sep 6, 2017

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.