Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libflux/flog: Support output to stderr #1192

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Sep 14, 2017

Make flux handle optional in logging functions. If flux handle
is NULL, output to stderr.

Add unit tests appropriately.

Fixes #1191

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 14, 2017

I think primary review is on format of output:

return fprintf (stderr, "%s: %s\n", lstr, buf);

No colon? Upper case priority level string? I elected on colon and lower case.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Sep 14, 2017

Looks good! Don't forget a mention in flux_log(3).

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 15, 2017

Coverage Status

Changes Unknown when pulling 7fd9a3b on chu11:issue1191 into ** on flux-framework:master**.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 15, 2017

Hmm, I had one build failure

PASS: t0001-basic.t 53 - instance can stop cleanly with subscribers (#1025)
ERROR: t0001-basic.t - missing test plan
ERROR: t0001-basic.t - exited with status 1

Which suggests my test seg-faulted or something like that. hmmm.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Sep 15, 2017

No colon? Upper case priority level string? I elected on colon and lower case.

Sounds ok to me.

libflux/flog: Support output to stderr
Make flux handle optional in logging functions.  If flux handle
is NULL, output to stderr.

Update documentation and add unit tests appropriately.

Fixes #1191

@chu11 chu11 force-pushed the chu11:issue1191 branch from 7fd9a3b to 670fbaa Sep 15, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 15, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@06a2ec8). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1192   +/-   ##
=========================================
  Coverage          ?   77.81%           
=========================================
  Files             ?      158           
  Lines             ?    29288           
  Branches          ?        0           
=========================================
  Hits              ?    22789           
  Misses            ?     6499           
  Partials          ?        0
Impacted Files Coverage Δ
src/common/libflux/flog.c 93.49% <100%> (ø)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 15, 2017

Coverage Status

Changes Unknown when pulling 670fbaa on chu11:issue1191 into ** on flux-framework:master**.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 15, 2017

pushed manpage updates & pushed fix for issue I listed above (failed chain lint was the issue).

first run through travis hit #1169 and some write errors, restarting

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Sep 15, 2017

Thanks! Looks good.

@garlick garlick merged commit 3cd405f into flux-framework:master Sep 15, 2017

2 of 4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 78.16%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.