Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#1194: delay thread cancellation during sqlite. #1196

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
4 participants
@nikhil-jain
Copy link
Contributor

nikhil-jain commented Sep 21, 2017

If thread cancellation interrupts sqlite operation, the main thread may not be
able to acquire lock inside sqlite calls during clean up and hangs.

@nikhil-jain nikhil-jain force-pushed the nikhil-jain:nikhil/sqlite-fix branch from 0816055 to 36e6209 Sep 21, 2017

Bug#1194: delay thread cancellation during sqlite.
If thread cancellation interrupts sqlite operation, the main thread may not be
able to acquire lock inside sqlite calls during clean up and hangs.

Change-Id: Iec9a50fff01aa5f0b24b56c3b7959929ab39c8ad

@nikhil-jain nikhil-jain force-pushed the nikhil-jain:nikhil/sqlite-fix branch from 36e6209 to b502575 Sep 21, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage decreased (-0.04%) to 78.139% when pulling 36e6209 on nikhil-jain:nikhil/sqlite-fix into e570bd7 on flux-framework:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage decreased (-0.05%) to 78.128% when pulling b502575 on nikhil-jain:nikhil/sqlite-fix into e570bd7 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 21, 2017

Codecov Report

Merging #1196 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
- Coverage   77.81%   77.81%   -0.01%     
==========================================
  Files         158      158              
  Lines       29292    29298       +6     
==========================================
+ Hits        22795    22798       +3     
- Misses       6497     6500       +3
Impacted Files Coverage Δ
src/modules/content-sqlite/content-sqlite.c 55.62% <100%> (+0.89%) ⬆️
src/broker/module.c 83.84% <0%> (-1.4%) ⬇️
src/broker/content-cache.c 73.27% <0%> (-1.3%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/common/libflux/future.c 88.31% <0%> (-0.47%) ⬇️
src/common/libflux/message.c 81.29% <0%> (+0.11%) ⬆️
src/common/libkvs/kvs.c 65.08% <0%> (+0.25%) ⬆️
src/modules/kvs/kvs.c 63.16% <0%> (+0.26%) ⬆️
src/common/libkvs/treeobj.c 83.41% <0%> (+0.46%) ⬆️
src/common/libkvs/kvs_txn.c 77.12% <0%> (+0.65%) ⬆️
... and 2 more
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Sep 21, 2017

Thanks! I restarted three failed travis builders. Two were write errors (a known intermittent failure) and one was a hang during the flux-cron sharness test. Likely unrelated to this PR.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage decreased (-0.01%) to 78.164% when pulling b502575 on nikhil-jain:nikhil/sqlite-fix into e570bd7 on flux-framework:master.

@garlick garlick merged commit f7883d9 into flux-framework:master Sep 21, 2017

4 checks passed

codecov/patch 100% of diff hit (target 77.81%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +22.18% compared to e570bd7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 78.164%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.