Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux.service: Fix EXTRA_DIST and .gitignore #1200

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
5 participants
@morrone
Copy link
Contributor

morrone commented Sep 25, 2017

Add flux.service to .gitignore, since it is generated from
flux.service.in at configure time.

Remove the EXTRA_DIST of flux.service. Since this is generated
at configure time from flux.service.in and flux.service.in
is already part of the dist by way of being declared in AC_CONFIG_FILES,
it does not appear that flux.service should be EXTRA_DIST.

flux.service: Fix EXTRA_DIST and .gitignore
Add flux.service .gitignore, since it is generated from
flux.service.in at configure time.

Remove the EXTRA_DIST of flux.service. Since this is generated
at configure time from flux.service.in and flux.service.in
is already part of the dist by way of being declared in AC_CONFIG_FILES,
it does not appear that flux.service should be EXTRA_DIST.

@morrone morrone requested review from garlick and grondo Sep 25, 2017

@grondo

grondo approved these changes Sep 25, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 25, 2017

Coverage Status

Coverage increased (+0.04%) to 78.214% when pulling 85a5c57 on morrone:flux.service into f7883d9 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 25, 2017

Codecov Report

Merging #1200 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
+ Coverage   77.82%   77.86%   +0.04%     
==========================================
  Files         158      158              
  Lines       29298    29298              
==========================================
+ Hits        22802    22814      +12     
+ Misses       6496     6484      -12
Impacted Files Coverage Δ
src/common/libflux/request.c 87.17% <0%> (-1.29%) ⬇️
src/modules/connector-local/local.c 74.27% <0%> (-1.28%) ⬇️
src/common/libflux/handle.c 83.66% <0%> (-0.5%) ⬇️
src/common/libcompat/handle.c 84.94% <0%> (-0.48%) ⬇️
src/broker/overlay.c 72.02% <0%> (-0.35%) ⬇️
src/common/libflux/message.c 81.64% <0%> (+0.23%) ⬆️
src/common/libkvs/kvs.c 65.34% <0%> (+0.51%) ⬆️
src/modules/kvs/kvs.c 63.43% <0%> (+0.53%) ⬆️
src/common/libflux/mrpc.c 86.32% <0%> (+1.17%) ⬆️
src/broker/content-cache.c 74.56% <0%> (+1.29%) ⬆️
... and 2 more
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Sep 25, 2017

Good catch.

@garlick garlick merged commit df4c58c into flux-framework:master Sep 25, 2017

4 checks passed

codecov/patch Coverage not affected when comparing f7883d9...85a5c57
Details
codecov/project 77.86% (+0.04%) compared to f7883d9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 78.214%
Details

@morrone morrone deleted the morrone:flux.service branch Sep 26, 2017

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.