Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration changes to support C++ code #1204

Merged
merged 4 commits into from Sep 26, 2017

Conversation

Projects
None yet
5 participants
@morrone
Copy link
Contributor

commented Sep 26, 2017

A few commits to update the configuration system to allow building C++ code.

morrone added some commits Sep 26, 2017

config: Convert @GCCWARN@ to $(WARNING_CFLAGS)
Change the name of GCCWARN to WARNING_CFLAGS to eliminate
the gcc-specificity from the name.  Granted it is unlikely, but
WARNING_CFLAGS might potentially have different values depending
on the detected compiler, without requiring changes to each
Makefile.am.  The name is also now in keeping with our other
*_CFLAGS named variables.

Also, we change from @GCCWARN@ to the more common variable usage
$(WARNING_CFLAGS).

This will help a little bit with coming C++ flags.
config: Update to a newer ax_code_coverage.m4
Update ax_code_coverage.m4 to the latest from
https://www.gnu.org/software/autoconf-archive/ax_code_coverage.html.

This new version supports C++ with a CODE_COVERAGE_CXXFLAGS variable.

Rename CODE_COVERAGE_CFLAGS to CODE_COVERAGE_LIBS since the newer
m4 file deprecates the former.
config: Introduce WARNING_CXXFLAGS
Introduce the WARNING_CXXFLAGS variable.

These will be useful for future C++ code.
config: Require that C++ use the C++11 standard
Introduce the AX_CXX_COMPILE_STDCXX macro from
 https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html.

Employ the macro to set the C++ compiler to use C++11.

@morrone morrone requested review from garlick and grondo Sep 26, 2017

@morrone

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2017

I might need travis relaunched on this. In the first error it just stalled after "t9990-python-tests.t 44 test.request.TestRequestMethods.test_null_payload". In the other one a run of configure failed here:

cat: write error: Resource temporarily unavailable

$ cat src/common/libflux/test_reactor.log
cat: src/common/libflux/test_reactor.log: No such file or directory


Done. Your build exited with 1.

I don't think that those were related to this pull request.

@garlick

This comment has been minimized.

Copy link
Member

commented Sep 26, 2017

That's one of the commonly recurring travis error. I restarted. If you're not seeing the little restart button on each build you might need to sign up for a travis account (it uses github auth).

@coveralls

This comment has been minimized.

Copy link

commented Sep 26, 2017

Coverage Status

Coverage increased (+0.5%) to 78.656% when pulling 9b111f7 on morrone:cxx_build_changes into df4c58c on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 26, 2017

Codecov Report

Merging #1204 into master will increase coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
+ Coverage   77.82%   78.24%   +0.41%     
==========================================
  Files         158      158              
  Lines       29298    29139     -159     
==========================================
- Hits        22801    22799       -2     
+ Misses       6497     6340     -157
Impacted Files Coverage Δ
src/common/libflux/keepalive.c 86.66% <0%> (-6.67%) ⬇️
src/common/libflux/future.c 88.31% <0%> (-0.94%) ⬇️
src/broker/content-cache.c 73.43% <0%> (-0.49%) ⬇️
src/common/libkvs/treeobj.c 82.94% <0%> (-0.47%) ⬇️
src/common/libkvs/kvs.c 65.08% <0%> (-0.26%) ⬇️
src/broker/module.c 83.79% <0%> (-0.05%) ⬇️
src/common/libflux/message.c 81.13% <0%> (+0.07%) ⬆️
src/common/libjsc/jstatctl.c 78.8% <0%> (+0.11%) ⬆️
src/common/libsubprocess/subprocess.c 81.85% <0%> (+0.17%) ⬆️
src/modules/cron/cron.c 79.67% <0%> (+0.18%) ⬆️
... and 32 more
@garlick
Copy link
Member

left a comment

This looks OK to me, and passed a test build (autogen through make check) on c9.io.

@grondo should weigh in on the ax_code_coverage.m4 update.

@grondo

grondo approved these changes Sep 26, 2017

Copy link
Contributor

left a comment

This is great, thanks!

@grondo grondo merged commit 6486563 into flux-framework:master Sep 26, 2017

4 checks passed

codecov/patch Coverage not affected when comparing df4c58c...9b111f7
Details
codecov/project 78.24% (+0.41%) compared to df4c58c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.5%) to 78.656%
Details

@morrone morrone deleted the morrone:cxx_build_changes branch Sep 26, 2017

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.