Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs.h add extern "C" wrapper #1225

Merged
merged 2 commits into from Oct 9, 2017

Conversation

Projects
None yet
4 participants
@morrone
Copy link
Contributor

morrone commented Oct 9, 2017

Fix missing extern "C" wrapper in kvs.h from issue #1223 PR, as mentioned in issue #1224.

morrone added some commits Oct 9, 2017

kvs: Remove unnecessary includes
Remove unnecessary includes from kvs.h.
kvs: Add extern "C" for C++ code
Add extern "C" for C++ code.  Was missed from a recent PR
as mentioned in issue #1224.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 9, 2017

Coverage Status

Coverage increased (+0.02%) to 78.639% when pulling a5c7e6f on morrone:kvs_cplusplus into fd68af2 on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 9, 2017

Restarted one builder that failed with the "write error" issue.

@garlick garlick changed the title kvs.h add extern "C" warpper kvs.h add extern "C" wrapper Oct 9, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 9, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@fd68af2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1225   +/-   ##
=========================================
  Coverage          ?   78.23%           
=========================================
  Files             ?      158           
  Lines             ?    29297           
  Branches          ?        0           
=========================================
  Hits              ?    22921           
  Misses            ?     6376           
  Partials          ?        0
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 9, 2017

Ok, took a few tries but the final build was successful, so merging!

@grondo grondo merged commit c43a1f1 into flux-framework:master Oct 9, 2017

3 of 4 checks passed

codecov/project No report found to compare against
Details
codecov/patch Coverage not affected when comparing fd68af2...a5c7e6f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 78.639%
Details

@morrone morrone deleted the morrone:kvs_cplusplus branch Oct 12, 2017

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.