Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KVS: Misc cleanup, add test coverage, minor bug fix #1235

Merged
merged 5 commits into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Oct 12, 2017

Spliced out these patches from #1227 and a forthcoming PR for #1232.

chu11 added some commits Oct 11, 2017

modules/kvs/test: Add cache tests
Create waiter tests to work with raw data cache entries.
modules/kvs: Fix errnum return corner case
Fix corner case in which error from commit wasn't passed to
cleanup path correctly.
modules/kvs: Rename commit callback types
Per style guidelines in RFC 7, rename function typedefs with '_f' at
the end of the name.  More specificlly, rename commit_ref_cb to commit_ref_f
and commit_cache_entry_cb to commit_cache_entry_f.

@chu11 chu11 force-pushed the chu11:misccleanup10 branch from 395a179 to 0e4f97f Oct 12, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 12, 2017

Codecov Report

Merging #1235 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
+ Coverage   78.13%   78.14%   +0.01%     
==========================================
  Files         154      154              
  Lines       28665    28665              
==========================================
+ Hits        22397    22401       +4     
+ Misses       6268     6264       -4
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 64.26% <100%> (+0.26%) ⬆️
src/modules/kvs/commit.c 76.68% <100%> (ø) ⬆️
src/common/libflux/handle.c 83.66% <0%> (-2.23%) ⬇️
src/cmd/flux-event.c 67.74% <0%> (-1.08%) ⬇️
src/common/libkvs/kvs_watch.c 86.34% <0%> (-0.89%) ⬇️
src/broker/overlay.c 71.92% <0%> (-0.36%) ⬇️
src/bindings/lua/flux-lua.c 81.18% <0%> (-0.09%) ⬇️
src/common/libflux/message.c 81.48% <0%> (ø) ⬆️
src/modules/connector-local/local.c 76.07% <0%> (+0.18%) ⬆️
src/common/libkvs/kvs.c 65.62% <0%> (+0.25%) ⬆️
... and 6 more
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 12, 2017

re-pushed, I didn't like one of my commit messages. Code is all the same.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 12, 2017

Coverage Status

Changes Unknown when pulling 395a179 on chu11:misccleanup10 into ** on flux-framework:master**.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 12, 2017

This looks good. I'm so glad for all the unit tests!

I'll merge when it turns green.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 12, 2017

Coverage Status

Changes Unknown when pulling 0e4f97f on chu11:misccleanup10 into ** on flux-framework:master**.

@garlick garlick merged commit 1893b92 into flux-framework:master Oct 13, 2017

4 checks passed

codecov/patch 100% of diff hit (target 78.13%)
Details
codecov/project 78.14% (+0.01%) compared to c6412bf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 78.719%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.