Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/kvs: Replace EPERM w/ ENOTRECOVERABLE #1242

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Oct 18, 2017

Previously EPERM was generally used as the errno to signify that
the state without the KVS was inconsistent/illogical (e.g. a
dirref points to a val object). To remove confusion that a
potential security issue is in play, change the errno from EPERM
to ENOTRECOVERABLE.

Update unit tests appropriately.

Fixes #1228

modules/kvs: Replace EPERM w/ ENOTRECOVERABLE
Previously EPERM was generally used as the errno to signify that
the state without the KVS was inconsistent/illogical (e.g. a
dirref points to a val object).  To remove confusion that a
potential security issue is in play, change the errno from EPERM
to ENOTRECOVERABLE.

Update unit tests appropriately.

Fixes #1228
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-0.004%) to 78.679% when pulling d3fe8e2 on chu11:issue1228 into eebb5e7 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 18, 2017

Codecov Report

Merging #1242 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
+ Coverage   78.08%   78.08%   +<.01%     
==========================================
  Files         154      154              
  Lines       28812    28812              
==========================================
+ Hits        22497    22498       +1     
+ Misses       6315     6314       -1
Impacted Files Coverage Δ
src/modules/kvs/lookup.c 84.18% <50%> (ø) ⬆️
src/modules/kvs/commit.c 76.68% <50%> (ø) ⬆️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/common/libflux/message.c 81.25% <0%> (-0.36%) ⬇️
src/common/libkvs/kvs.c 64.87% <0%> (+0.24%) ⬆️
src/modules/kvs/kvs.c 63.52% <0%> (+0.25%) ⬆️
src/common/libutil/dirwalk.c 94.28% <0%> (+0.71%) ⬆️
src/common/libflux/attr.c 88.88% <0%> (+0.88%) ⬆️
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 18, 2017

coverage diff is unsurprisingly low, as many "impossible" paths are missed

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 18, 2017

Looks good, thanks.

@garlick garlick merged commit e1a1d87 into flux-framework:master Oct 18, 2017

3 of 4 checks passed

codecov/patch 50% of diff hit (target 78.08%)
Details
codecov/project 78.08% (+<.01%) compared to eebb5e7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 78.679%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.