Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
KVS modify commit protocol in preparation for append #1243
This PR changes the request message format for KVS commit/fence to incorporate a
Since operations were encoded/decoded in several places, I added new (internal to KVS client and server) functions
While adding this to the commit code, I fixed an error handling oversight that would allow a commit request to silently ignore a malformed operation and return success to the caller.
Finally, the KVS flags definitions were moved to kvs.h from kvs_lookup.h. They are not lookup specific. I didn't add an append flag yet though - we can do that when we have support on the server end for it.
3 times, most recently
Oct 19, 2017
Do we care about breaking TOSS 2 systems these days? /opt on hype is python2.7-cffi-1.1.2...
my desktop (Ubuntu 16.04.3 LTS) has python-cffi-1.5.2 and is working.
ipa (TOSS 3) has python-cffi-1.6.0-5
I'll go ahead and change travis to 1.5 and see how that goes.
We didn't build a new package for TOSS 2 last time, not sure we have any users on that platform. But I agree we can just updated the cffi package if we need it in the future.
@@ Coverage Diff @@ ## master #1243 +/- ## ========================================== - Coverage 78.02% 77.99% -0.04% ========================================== Files 154 154 Lines 28933 28961 +28 ========================================== + Hits 22576 22588 +12 - Misses 6357 6373 +16
Bad travis day! I restarted 5 builders that got write errors, and one that hung in the sharness cron test.
Also restarted a hung master build from the last merge that is preventing codecov from reporting results.
I have that test queued up and will submit after that master build finishes.