Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kvs: refactor kvs cache to handle raw data as "primary" data #1246
This PR refactors the KVS cache to favor the storage of raw data over json objects. This accomplishes several goals.
The primary idea behind this refactor to remove the "type" system with KVS cache entries and make the KVS cache primarily for storing raw data.
Users can set get/set json objects in the KVS cache, but the API is simply a set of convenience functions converting those json objects to/from their raw string form.
As an aside, I am sometimes anal when it comes to code "ordering". In commit chu11@368f858 I literally just move "json" code below "raw data" code, b/c I want "raw data" code to be listed first as it is now the "primary" way the KVS cache works. I know its more code change than may be necessary.
@@ Coverage Diff @@ ## master #1246 +/- ## ========================================== - Coverage 77.99% 77.93% -0.06% ========================================== Files 154 154 Lines 28964 28902 -62 ========================================== - Hits 22590 22525 -65 - Misses 6374 6377 +3
just re-pushed with some fixes. Removed
Changed the logic in
Removed unnecessary checks for NULL in
Will do the cleanup regarding consistent dirty bit and valid bit in a separate PR (#1247).