Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: only set warning flags for GNU and Clang #1252

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Oct 24, 2017

Import AX_COMPILER_VENDOR autoconf-archive macro and use the
discovered vendor to determine whether to set WARNING_CFLAGS and
WARNING_CXXFLAGS instead of using $GCC = "yes". Turns out that $GCC is
set to "yes" whenever GNUC is defined by the compiler, and this
doesn't imply strict compatibility with gcc.

Fixes #1251

build: only set warning flags for GNU and Clang
Import AX_COMPILER_VENDOR autoconf-archive macro and use the
discovered vendor to determine whether to set WARNING_CFLAGS and
WARNING_CXXFLAGS instead of using $GCC = "yes". Turns out that $GCC is
set to "yes" whenever __GNUC__ is defined by the compiler, and this
doesn't imply strict compatibility with gcc.

Fixes #1251
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 24, 2017

restarted one travis builder that hung in the cron sharness test

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 24, 2017

Restarted again - this time hung very early in environment setup.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.03%) to 78.493% when pulling 5d0872f on grondo:issue#1251 into 4e15246 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 24, 2017

Codecov Report

Merging #1252 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
- Coverage    77.9%   77.88%   -0.03%     
==========================================
  Files         154      154              
  Lines       28903    28903              
==========================================
- Hits        22518    22510       -8     
- Misses       6385     6393       +8
Impacted Files Coverage Δ
src/common/libflux/request.c 88.46% <0%> (-1.29%) ⬇️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/common/libutil/dirwalk.c 93.57% <0%> (-0.72%) ⬇️
src/common/libkvs/kvs_txn.c 76.11% <0%> (-0.56%) ⬇️
src/common/libflux/message.c 81.13% <0%> (-0.12%) ⬇️
src/bindings/lua/flux-lua.c 81.08% <0%> (-0.09%) ⬇️

@garlick garlick merged commit 39fd3cb into flux-framework:master Oct 25, 2017

3 of 4 checks passed

codecov/project 77.88% (-0.03%) compared to 4e15246
Details
codecov/patch Coverage not affected when comparing 4e15246...5d0872f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 78.493%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.