Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: actually disable pylint by default #1255

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Oct 25, 2017

In commit bd4fee8 the pylint check
was accidently left enabled by default. The intent was to have the
default be disabled and only run pylint on --enable-pylint.

Sorry! Not sure how that slipped through (I promise I tested functionality several times) 馃槩

build: disable pylint by default
In commit bd4fee8 the pylint check
was accidently left enabled by default. The intent was to have the
default be *disabled* and only run pylint on --enable-pylint.
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 25, 2017

restarted a builder stuck at the cron test.

I'm sorry I didn't catch that when I reviewed it and pushed the button!

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 25, 2017

I did verify this time that pylint is running in the one builder and not in the others. Probably no need to wait until that builder finishes. Merging.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 25, 2017

Oh except gray button :-)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage increased (+0.05%) to 78.541% when pulling 2ff4a07 on grondo:pylint-disable into 2694116 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 25, 2017

Codecov Report

Merging #1255 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
+ Coverage   77.88%   77.92%   +0.04%     
==========================================
  Files         154      154              
  Lines       28934    28934              
==========================================
+ Hits        22534    22548      +14     
+ Misses       6400     6386      -14
Impacted Files Coverage 螖
src/broker/overlay.c 73.88% <0%> (-0.32%) 猬囷笍
src/common/libflux/message.c 81.48% <0%> (-0.12%) 猬囷笍
src/common/libflux/response.c 84.55% <0%> (+0.81%) 猬嗭笍
src/broker/modservice.c 81.55% <0%> (+0.97%) 猬嗭笍
src/common/libflux/mrpc.c 86.66% <0%> (+1.17%) 猬嗭笍
src/broker/content-cache.c 74.73% <0%> (+1.29%) 猬嗭笍
src/broker/module.c 85.19% <0%> (+1.39%) 猬嗭笍

@garlick garlick merged commit 1220202 into flux-framework:master Oct 25, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 2694116...2ff4a07
Details
codecov/project 77.92% (+0.04%) compared to 2694116
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 78.541%
Details

@grondo grondo deleted the grondo:pylint-disable branch Oct 30, 2017

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.