Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: do not store NUL byte on json encoded strings in kvs server #1263

merged 2 commits into from Oct 29, 2017
Changes from 1 commit
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+3 −3
Diff settings


Just for now


modules/kvs: Update some legacy comments

  • Loading branch information...
chu11 committed Oct 27, 2017
commit 2b62d9f192ee66c57070bf76329798f14fbe48b3
Copy path View file
@@ -147,7 +147,7 @@ const char *commit_get_newroot_ref (commit_t *c)
* bit.
* As of the writing of this code, it should also be impossible
* for the cache_entry_removal() to fail. In the rare case of two
* for the cache_remove_entry() to fail. In the rare case of two
* callers kvs-get and kvs.put-ing items that end up at the
* blobref in the cache, any waiters for a valid cache entry would
* have been satisfied when the dirty cache entry was put onto
Copy path View file
@@ -43,7 +43,7 @@ char *kvs_util_json_dumps (json_t *o)
/* Must pass JSON_ENCODE_ANY, can be called on any object. Must
* set JSON_SORT_KEYS, two different objects with different
* internal order should map to same string (and reference when
* used by json_hash()).
* used by kvs_util_json_hash()).
char *s;
Copy path View file
@@ -8,7 +8,7 @@

/* Get compact string representation of json object, or json null
* object if o is NULL. Use this function for consistency, especially
* when dealing with data that may be hashed via json_hash().
* when dealing with data that may be hashed via kvs_util_json_hash().
* Returns NULL on error
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.