Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize valgrind suppression for getaddrinfo #1266

Merged
merged 1 commit into from Nov 1, 2017

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Oct 30, 2017

As noted in #1240, the valgrind test fails when building under spack on recent ubuntu because the stack trace for getaddrinfo() leak is slightly different than the existing suppression entry in this environment. This PR just generalizes that suppression so that any leak under getaddrinfo() is suppressed.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage decreased (-0.07%) to 78.515% when pulling ddf7569 on grondo:valgrind.supp into 3a286cb on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 31, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@00b06d1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1266   +/-   ##
=========================================
  Coverage          ?   77.91%           
=========================================
  Files             ?      154           
  Lines             ?    29093           
  Branches          ?        0           
=========================================
  Hits              ?    22667           
  Misses            ?     6426           
  Partials          ?        0
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Nov 1, 2017

This just needs a rebase. Thanks.

t5000-valgrind.t: generalize suppression for getaddrinfo
Generalize the suppression entry for leak detected under getaddrinfo()
to handle slight difference in call chain under different build
environments.

@grondo grondo force-pushed the grondo:valgrind.supp branch from ddf7569 to d1dd627 Nov 1, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 1, 2017

Coverage Status

Changes Unknown when pulling d1dd627 on grondo:valgrind.supp into ** on flux-framework:master**.

@garlick garlick merged commit 54c08c1 into flux-framework:master Nov 1, 2017

3 of 4 checks passed

codecov/project No report found to compare against
Details
codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 78.533%
Details

@grondo grondo deleted the grondo:valgrind.supp branch Nov 1, 2017

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.