Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest ax_lua.m4 #1275

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@morrone
Copy link
Contributor

morrone commented Nov 7, 2017

The older version of ax_lua.m4 that we used was failing to
abort when AX_LUA_HEADERS failed to find headers. That is
no longer a problem in the new ax_lua.m4.

Fixes #1270

Update to the latest ax_lua.m4
The older version of ax_lua.m4 that we used was failing to
abort when AX_LUA_HEADERS failed to find headers.  That is
no longer a problem in the new ax_lua.m4.

Fixes #1270
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 7, 2017

Codecov Report

Merging #1275 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
- Coverage   77.88%   77.87%   -0.02%     
==========================================
  Files         154      154              
  Lines       29124    29124              
==========================================
- Hits        22684    22680       -4     
- Misses       6440     6444       +4
Impacted Files Coverage Δ
src/common/libflux/request.c 88.46% <0%> (-1.29%) ⬇️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/broker/modservice.c 80.58% <0%> (-0.98%) ⬇️
src/common/libkvs/treeobj.c 85.82% <0%> (-0.39%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/common/libflux/handle.c 83.66% <0%> (-0.25%) ⬇️
src/common/libflux/message.c 81.36% <0%> (-0.24%) ⬇️
src/common/libkvs/kvs.c 64.03% <0%> (+0.24%) ⬆️
src/modules/kvs/kvs.c 62.62% <0%> (+0.25%) ⬆️
src/broker/overlay.c 74.2% <0%> (+0.31%) ⬆️
... and 1 more
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage decreased (-0.02%) to 78.493% when pulling 4a664e6 on morrone:ax_lua_update into d7300ec on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Nov 7, 2017

This looks good to me. Thanks for tracking that and running down the fix.

@grondo grondo merged commit 4456339 into flux-framework:master Nov 7, 2017

3 of 4 checks passed

codecov/project 77.87% (-0.02%) compared to d7300ec
Details
codecov/patch Coverage not affected when comparing d7300ec...4a664e6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 78.493%
Details

@morrone morrone deleted the morrone:ax_lua_update branch Nov 7, 2017

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.