Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kvs: cleanup / re-organize sharness tests #1276
Due to various changes in the KVS and flux-kvs the past few months, the kvs sharness tests have gotten a little disorganized, so I thought it'd be a good idea to go through them before we move onto the next big work.
A number of tests were eliminated because they were deemed unnecessary, most notably legacy tests related to all KVS objects being stored as json (everything is stored raw text now) and tests for now-gone functions.
There were a decent chunk of duplicate (or near duplicate) tests lingering, got rid of the duplicates.
Re-organized the KVS tests into four files
To accomodate the naming of these files, some other test files were re-numbered.
Admit that tests could be split up other ways. I went back and forth on a few different ideas, but this is what I settled on. Minimally its far more organized compared to what was there before.
oh boy the README is way out of date
I'm not entirely sure what pattern the tests may be following at this point. Especially when including the ones in
@@ Coverage Diff @@ ## master #1276 +/- ## ========================================= - Coverage 78.02% 77.92% -0.1% ========================================= Files 154 154 Lines 29097 29097 ========================================= - Hits 22702 22674 -28 - Misses 6395 6423 +28