Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: Add stats.clear test coverage #1291

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Nov 17, 2017

While working on #1286 , noticed there was no coverage for kvs.stats.clear. So added a few tests.

Also fixed a typo I found.

chu11 added some commits Nov 15, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 18, 2017

Coverage Status

Coverage increased (+0.03%) to 78.625% when pulling d5c3b23 on chu11:issue1287 into 3c3890c on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Nov 18, 2017

hit #1169, restarted a builder

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 18, 2017

Codecov Report

Merging #1291 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
+ Coverage   77.98%   78.05%   +0.07%     
==========================================
  Files         154      154              
  Lines       29104    29104              
==========================================
+ Hits        22696    22717      +21     
+ Misses       6408     6387      -21
Impacted Files Coverage Δ
src/common/libflux/handle.c 83.66% <0%> (-2.73%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/bindings/lua/flux-lua.c 81.16% <0%> (+0.08%) ⬆️
src/common/libflux/message.c 81.25% <0%> (+0.11%) ⬆️
src/broker/overlay.c 74.2% <0%> (+0.31%) ⬆️
src/common/libflux/future.c 88.78% <0%> (+0.46%) ⬆️
src/broker/modservice.c 81.55% <0%> (+0.97%) ⬆️
src/modules/kvs/kvs.c 65.21% <0%> (+1.66%) ⬆️
src/common/libkvs/kvs.c 66.78% <0%> (+1.83%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Nov 22, 2017

Oh, sorry @chu11, I forgot this was still pending! Thanks for adding the test, looks good.

@garlick garlick merged commit a2b1063 into flux-framework:master Nov 22, 2017

5 checks passed

buildbot/core_standard Build done.
Details
codecov/patch Coverage not affected when comparing 3c3890c...d5c3b23
Details
codecov/project 78.05% (+0.07%) compared to 3c3890c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 78.625%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.