Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/kvs: Refactor lookup_create() #1300

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Dec 7, 2017

Remove root_dir parameter to lookup_create(). It was only used
for one corner case, which in reality is not needed.

Instead, when user passes in root dir path (i.e. "."), it will return
the root reference that was passed in by the user. It does not need
to return the "real" root reference.

Update unit tests appropriately.

Fixes #1297

modules/kvs: Refactor lookup_create()
Remove root_dir parameter to lookup_create().  It was only used
for one corner case, which in reality is not needed.

Instead, when user passes in root dir path (i.e. "."), it will return
the root reference that was passed in by the user.  It does not need
to return the "real" root reference.

Update unit tests appropriately.

Fixes #1297
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 7, 2017

Coverage Status

Coverage increased (+0.01%) to 78.56% when pulling de3cff7 on chu11:issue1297 into 57e24fa on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Dec 7, 2017

hit #1150, restart build

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #1300 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
+ Coverage   78.21%   78.23%   +0.01%     
==========================================
  Files         154      154              
  Lines       27941    27931      -10     
==========================================
- Hits        21855    21851       -4     
+ Misses       6086     6080       -6
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.57% <ø> (-0.04%) ⬇️
src/modules/kvs/lookup.c 79.56% <100%> (-0.44%) ⬇️
src/common/libflux/response.c 83.73% <0%> (-0.82%) ⬇️
src/common/libflux/future.c 88.31% <0%> (-0.47%) ⬇️
src/common/libflux/message.c 81.48% <0%> (+0.11%) ⬆️
src/broker/module.c 84.07% <0%> (+0.27%) ⬆️
src/common/libutil/base64.c 95.77% <0%> (+0.7%) ⬆️
src/common/libutil/dirwalk.c 94.28% <0%> (+0.71%) ⬆️
src/common/libflux/mrpc.c 86.66% <0%> (+1.17%) ⬆️
src/common/libflux/request.c 89.74% <0%> (+1.28%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 7, 2017

LGTM!

@garlick garlick merged commit 53697fa into flux-framework:master Dec 7, 2017

5 checks passed

buildbot/core_standard Build done.
Details
codecov/patch 100% of diff hit (target 78.21%)
Details
codecov/project 78.23% (+0.01%) compared to 57e24fa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 78.56%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.