Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobspec: Use "yaml-cpp" instead of "Yaml-cpp" #1306

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
4 participants
@dongahn
Copy link
Contributor

dongahn commented Dec 12, 2017

Fix a flux-sched autoconf problem when it uses
PKG_CHECK_MODULES to gather libraray info on jobspec
package.

Apparently pkg-config doesn't like the dependent
package name: "Yaml-cpp."

On quartz:
$ uname -a
Linux quartz1916 3.10.0-693.5.2.1chaos.ch6.x86_64 #1
SMP Wed Oct 25 16:20:31 PDT 2017 x86_64 x86_64 x86_64 GNU/Linux

$ pkg-config --cflags flux-jobspec
Package Yaml-cpp was not found in the pkg-config search path.
Perhaps you should add the directory containing `Yaml-cpp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'Yaml-cpp', required by 'flux-jobspec', not found

Get a simiar configure error when
PKG_CHECK_MODULES([JOBSPEC],[flux-jobspec],[],[]) is used.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 13, 2017

Coverage Status

Coverage increased (+0.07%) to 78.616% when pulling c500d7e on dongahn:jobspec-pkg-fix into 53697fa on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 13, 2017

Codecov Report

Merging #1306 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
+ Coverage   78.22%   78.28%   +0.06%     
==========================================
  Files         154      154              
  Lines       27935    27935              
==========================================
+ Hits        21851    21868      +17     
+ Misses       6084     6067      -17
Impacted Files Coverage Δ
src/common/libflux/future.c 88.78% <0%> (-0.47%) ⬇️
src/broker/module.c 84.07% <0%> (+0.27%) ⬆️
src/broker/overlay.c 74.2% <0%> (+0.31%) ⬆️
src/common/libflux/message.c 81.6% <0%> (+0.47%) ⬆️
src/common/libutil/base64.c 95.77% <0%> (+0.7%) ⬆️
src/common/libflux/mrpc.c 86.66% <0%> (+1.17%) ⬆️
src/common/libflux/request.c 89.74% <0%> (+1.28%) ⬆️
src/modules/connector-local/local.c 74.38% <0%> (+1.43%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 13, 2017

Interesting. I checked on my ubuntu system, and the pc file names the package with upper case Y:

prefix=/usr
exec_prefix=/usr
includedir=${prefix}/include

Name: Yaml-cpp
Description: A YAML parser and emitter for C++
Version: 0.5.2
Requires:
Libs: -lyaml-cpp
Cflags: -I${includedir}

however, only all lower case seems to work with pkg-config:

$ pkg-config --modversion yaml-cpp
0.5.2
$ pkg-config --modversion Yaml-cpp
Package Yaml-cpp was not found in the pkg-config search path.
Perhaps you should add the directory containing `Yaml-cpp.pc'
to the PKG_CONFIG_PATH environment variable
No package 'Yaml-cpp' found

So looks good to me. Needs a rebase now though (sorry).

@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Dec 13, 2017

Not a problem. Will do shortly.

jobspec: Use "yaml-cpp" instead of "Yaml-cpp"
Fix a flux-sched autoconf problem when it uses
PKG_CHECK_MODULES to gather libraray info on jobspec
package.

Apparently pkg-config doesn't like the dependent
package name: "Yaml-cpp."

On quartz:
$ uname -a
Linux quartz1916 3.10.0-693.5.2.1chaos.ch6.x86_64 #1
SMP Wed Oct 25 16:20:31 PDT 2017 x86_64 x86_64 x86_64 GNU/Linux

$ pkg-config --cflags flux-jobspec
Package Yaml-cpp was not found in the pkg-config search path.
Perhaps you should add the directory containing `Yaml-cpp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'Yaml-cpp', required by 'flux-jobspec', not found

Get a simiar configure error when
PKG_CHECK_MODULES([JOBSPEC],[flux-jobspec],[],[]) is used.
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Dec 13, 2017

Ok. Rebased and forced a push.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 13, 2017

Coverage Status

Coverage increased (+0.06%) to 78.608% when pulling 4db5c60 on dongahn:jobspec-pkg-fix into b43aca0 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 13, 2017

Thanks!

@garlick garlick merged commit c83814e into flux-framework:master Dec 13, 2017

5 checks passed

buildbot/core_standard Build done.
Details
codecov/patch Coverage not affected when comparing b43aca0...4db5c60
Details
codecov/project 78.28% (+0.06%) compared to b43aca0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 78.608%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.