Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: minor cleanup #1308

Merged
merged 6 commits into from Dec 15, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Dec 15, 2017

misc patches spliced out of my larger remove namespace PR. All simple and obvious.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #1308 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1308      +/-   ##
=========================================
- Coverage   78.23%   78.2%   -0.03%     
=========================================
  Files         154     154              
  Lines       27935   27937       +2     
=========================================
- Hits        21855   21849       -6     
- Misses       6080    6088       +8
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.57% <100%> (-0.21%) ⬇️
src/modules/kvs/commit.c 77.8% <100%> (+0.82%) ⬆️
src/common/libflux/request.c 87.17% <0%> (-1.29%) ⬇️
src/broker/modservice.c 79.61% <0%> (-0.98%) ⬇️
src/common/libflux/response.c 83.73% <0%> (-0.82%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/common/libflux/message.c 81.13% <0%> (-0.48%) ⬇️
src/broker/overlay.c 73.88% <0%> (-0.32%) ⬇️
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage increased (+0.004%) to 78.566% when pulling 258b45a on chu11:miscleanup12 into 2879f60 on flux-framework:master.

chu11 added some commits Dec 7, 2017

modules/kvs: Refactor root lookup
Create lookup_root() to refactor away root lookup call.
modules/kvs: Refactor error_event_send()
Function takes a string namespace instead of a kvsroot.

@chu11 chu11 force-pushed the chu11:miscleanup12 branch from 258b45a to 061661d Dec 15, 2017

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Dec 15, 2017

oops, forgot a patch. threw one more patch into this misc-cleanup PR

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage decreased (-0.03%) to 78.536% when pulling 061661d on chu11:miscleanup12 into 2879f60 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 15, 2017

LGTM - thanks!

@garlick garlick merged commit fb37531 into flux-framework:master Dec 15, 2017

5 checks passed

buildbot/core_standard Build done.
Details
codecov/patch 100% of diff hit (target 78.23%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +21.76% compared to 2879f60
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 78.536%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.