Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: add more kvs stats #1310

Merged
merged 3 commits into from Dec 15, 2017

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Dec 15, 2017

This PR is peeled off from my namespace remove work. It feels semi-independent of the larger work and decided it may be useful to put it off in its own PR.

This is independent of #1309 .

chu11 added some commits Dec 11, 2017

modules/kvs: Add new commit stat get functions
Support commit_mgr_fences_count() and commit_mgr_ready_commit_count()
to retrieve fences and ready commit counts.  Will be needed for
namespace removal and general stat checking.

Add new unit tests appropriately.
modules/kvs: Add new stats to kvs stats
Get commit mgr fence count and ready commit count.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #1310 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
- Coverage   78.25%   78.22%   -0.03%     
==========================================
  Files         154      154              
  Lines       27937    27941       +4     
==========================================
- Hits        21862    21857       -5     
- Misses       6075     6084       +9
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.57% <100%> (-0.21%) ⬇️
src/modules/kvs/commit.c 78.01% <100%> (+0.2%) ⬆️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/common/libflux/response.c 83.73% <0%> (-0.82%) ⬇️
src/broker/overlay.c 73.88% <0%> (-0.32%) ⬇️
src/common/libflux/message.c 81.25% <0%> (-0.24%) ⬇️
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 15, 2017

Coverage Status

Coverage decreased (-0.03%) to 78.553% when pulling 6cdb269 on chu11:kvsmorestats into fb37531 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 15, 2017

Looks good - thanks!

@garlick garlick merged commit 72d3059 into flux-framework:master Dec 15, 2017

5 checks passed

buildbot/core_standard Build done.
Details
codecov/patch 100% of diff hit (target 78.25%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +21.74% compared to fb37531
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 78.553%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.