Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: check that fence parameters are identical #1329

Merged
merged 5 commits into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Feb 9, 2018

This fixes #1305, as fence documentation and kvs server behavior did not match. IMO, the documentation indicated what the appropriate behavior should be, so code was adjusted to match it, and unit tests added.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 9, 2018

Coverage Status

Coverage increased (+0.01%) to 78.557% when pulling 113c997 on chu11:kvsfencerules into fafcf6a on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 9, 2018

Codecov Report

Merging #1329 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   78.22%   78.23%   +0.01%     
==========================================
  Files         156      156              
  Lines       28315    28321       +6     
==========================================
+ Hits        22150    22158       +8     
+ Misses       6165     6163       -2
Impacted Files Coverage Δ
src/modules/kvs/fence.c 84.26% <100%> (ø) ⬆️
src/modules/kvs/kvs.c 65.62% <75%> (-0.18%) ⬇️
src/common/libkvs/treeobj.c 85.14% <0%> (-0.41%) ⬇️
src/broker/overlay.c 73.88% <0%> (-0.32%) ⬇️
src/common/libflux/message.c 81.36% <0%> (ø) ⬆️
src/common/libflux/future.c 88.78% <0%> (ø) ⬆️
src/broker/module.c 84.07% <0%> (+0.27%) ⬆️
src/common/libflux/handle.c 84.15% <0%> (+0.49%) ⬆️
src/broker/modservice.c 80.58% <0%> (+0.97%) ⬆️
... and 2 more
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 9, 2018

Thanks, with bonus test even! Needs a rebase.

chu11 added some commits Feb 8, 2018

modules/kvs: Add fence checks
Previously, fences could be updated with new flags.  Instead,
require users to always specify the same nprocs and flags with
each fence request.  Return error if user does not.

Fixes #1305
t/kvs: Add fence_invalid test
Add test to ensure fence captures an invalid flag/nproc value.

@chu11 chu11 force-pushed the chu11:kvsfencerules branch from 66859ea to 113c997 Feb 9, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 9, 2018

rebased and pushed. Also added a commit that fixes one lingering "namespace" -> "name_space", as was done in #1327.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 9, 2018

Restarted a builder that failed here, a recurrence of #1077

not ok 53 - instance can stop cleanly with subscribers (#1025)

expecting success: 
        ${FLUX_BUILD_DIR}/t/loop/logstderr > std.out 2> std.err &&
        grep "warning: hello" std.err &&
        grep "err: world: No such file or directory" std.err

warning: hello
err: world: No such file or directory
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 9, 2018

Restarted another one that hung, last message was:

PASS: t4000-issues-test-driver.t 4 - t0900-wreck-invalid-cores.sh
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 9, 2018

That last one is #1311. Valgrind is taking too long, doesn't output anything, and eventually the 10 minutes is up.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 9, 2018

OK, merging this - thanks

@garlick garlick merged commit 04d2409 into flux-framework:master Feb 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 78.557%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.