Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kvs: Support ability to list namespaces #1336
@@ Coverage Diff @@ ## master #1336 +/- ## ========================================= + Coverage 78.21% 78.3% +0.09% ========================================= Files 156 156 Lines 28321 28405 +84 ========================================= + Hits 22151 22243 +92 + Misses 6170 6162 -8
I'd probably flatten the new service method name, since the extra period implies a module hierarchy (see intro in RFC 5), e.g. use
It might be a good idea to have a name column wide enough for a uuid in RFC 4122 ascii form, e.g.
since it's handy to create a unique KVS namespace that way, if no other source of uniqueness is available.
Just re-pushed with spacing enough to handle uuid width.
Noticed coverage didn't hit 78%, so I reworked some code in the kvs module. There is no need to handle the "zero namespaces" path, since
Changes are tiny and went ahead and squashed it all.
I see your point. How about we clean that up within the context of #1302 instead. Because I should probably correct that in a lot of places (