Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libflux/rpc: Rename flux_mrpcf() and flux_mrpc_getf() #1338

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Feb 14, 2018

For consistency, rename flux_mrpcf() to flux_mrpc_pack()
and rename flux_mrpc_getf() to flux_mrpc_get_unpack() just
as the changes were done in these prior commits.

libflux/rpc: rename rpcf->rpc_pack

9a5c28b

and

libflux/rpc: rename rpc_getf->rpc_get_unpack

1a3626b

Fixes #1290

libflux/rpc: Rename flux_mrpcf() and flux_mrpc_getf()
For consistency, rename flux_mrpcf() to flux_mrpc_pack()
and rename flux_mrpc_getf() to flux_mrpc_get_unpack() just
as the changes were done in these prior commits.

libflux/rpc: rename rpcf->rpc_pack

9a5c28b

and

libflux/rpc: rename rpc_getf->rpc_get_unpack

1a3626b

Fixes #1290
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 14, 2018

Coverage Status

Coverage increased (+0.02%) to 78.573% when pulling a2445cd on chu11:issue1290 into 1b7d626 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 14, 2018

Codecov Report

Merging #1338 into master will increase coverage by 0.01%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   78.22%   78.24%   +0.01%     
==========================================
  Files         156      156              
  Lines       28405    28405              
==========================================
+ Hits        22221    22226       +5     
+ Misses       6184     6179       -5
Impacted Files Coverage Δ
src/common/libflux/mrpc.c 86.66% <100%> (ø) ⬆️
src/cmd/builtin/hwloc.c 80.36% <50%> (ø) ⬆️
src/cmd/flux-ping.c 86.86% <66.66%> (ø) ⬆️
src/common/libflux/request.c 87.17% <0%> (-1.29%) ⬇️
src/broker/overlay.c 73.88% <0%> (-0.32%) ⬇️
src/cmd/flux-module.c 85.06% <0%> (-0.31%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/common/libflux/message.c 81.36% <0%> (+0.11%) ⬆️
src/common/libflux/response.c 84.55% <0%> (+0.81%) ⬆️
src/modules/connector-local/local.c 74.38% <0%> (+1.43%) ⬆️
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 14, 2018

This PR is only search & replaces, so low diff coverage appears to be just missed error paths.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 14, 2018

LGTM!

@garlick garlick merged commit 7495042 into flux-framework:master Feb 14, 2018

3 of 4 checks passed

codecov/patch 72.72% of diff hit (target 78.22%)
Details
codecov/project 78.24% (+0.01%) compared to 1b7d626
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 78.573%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.