Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: cleanup callback names #1339

Merged
merged 3 commits into from Feb 14, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Feb 14, 2018

Minor cleanup of the callback names in the kvs module. Some changes reflect more current naming styles within the KVS, and some were to remove use of periods per RFC 5.

chu11 added some commits Feb 14, 2018

modules/kvs: Rename fence callbacks
Rename to kvs.fence and kvs.relayfence to kvs.commit and
kvs.relaycommit.  Adjust function names appropriately.
modules/kvs: Rename "get" callbacks
Rename kvs.get to kvs.lookup and adjust function names appropriately.
modules/kvs: Remove periods from callback names
Per RFC 5, periods should be used to separate names in modules
extensions.  So remove periods from all kvs callbacks that should
not be using periods.  For example, "kvs.namespace.create" is now
"kvs.namespace-create".

Fixes #1302
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 14, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@7495042). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #1339   +/-   ##
========================================
  Coverage          ?   78.3%           
========================================
  Files             ?     156           
  Lines             ?   28405           
  Branches          ?       0           
========================================
  Hits              ?   22242           
  Misses            ?    6163           
  Partials          ?       0
Impacted Files Coverage Δ
src/common/libkvs/kvs_commit.c 83.33% <100%> (ø)
src/common/libkvs/kvs_lookup.c 77.69% <100%> (ø)
src/common/libkvs/kvs.c 90.52% <100%> (ø)
src/modules/kvs/kvs.c 65.73% <100%> (ø)
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 14, 2018

Thanks! I'll go ahead and merge, but did want to mention that the event topic strings aren't subject to the service routing rules that request topic strings are (they are broadcast so everybody potentially gets every event, if they subscribe). The renamed events are fine though.

@garlick garlick merged commit c5154a8 into flux-framework:master Feb 14, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 78.628%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.