Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kvs: cleanup callback names #1339
@@ Coverage Diff @@ ## master #1339 +/- ## ======================================== Coverage ? 78.3% ======================================== Files ? 156 Lines ? 28405 Branches ? 0 ======================================== Hits ? 22242 Misses ? 6163 Partials ? 0
Thanks! I'll go ahead and merge, but did want to mention that the event topic strings aren't subject to the service routing rules that request topic strings are (they are broadcast so everybody potentially gets every event, if they subscribe). The renamed events are fine though.