Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: minor fixes/cleanup #1342

Merged
merged 5 commits into from Feb 20, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Feb 17, 2018

Minor things I fixed up on the way to fixing #1337.

chu11 added some commits Feb 14, 2018

module/kvs: Refactor commit_process()
Remove unnecessary branch check, as ops array is always non-NULL
(but can be an empty array).
modules/fence: Rename fence_add_request_data()
Rename to fence_add_request_ops(), which makes more sense.
common/libkvs: Check inputs in flux_kvs_fence
Check that name is not NULL and nprocs is > 0.
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 20, 2018

not entirely sure why travis hasn't started this yet, is there a way to kick it?

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Feb 20, 2018

You might have to make a minor change and re-push, unless the PR has already been built at least once at https://travis-ci.org/flux-framework/flux-core/pull_requests, in which case you can restart the build via the travis interface there.

modules/kvs: Add fence_create() input check
Check that name is not NULL and nprocs is > 0.

@chu11 chu11 force-pushed the chu11:issue1337-part1 branch from 1425e3a to 134370e Feb 20, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 20, 2018

did a tiny change and that seems to have done it.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 20, 2018

hit a #1150, restarted build

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 20, 2018

Coverage Status

Coverage increased (+0.01%) to 78.588% when pulling 134370e on chu11:issue1337-part1 into c5154a8 on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Feb 20, 2018

then I hit #1077, restart build

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Feb 20, 2018

Looks good, thanks!

@garlick garlick merged commit 6a37017 into flux-framework:master Feb 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 78.588%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.