Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: minor fixes/cleanups #1353

Merged
merged 3 commits into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Mar 8, 2018

While working on #1352 (which is now closed and won't be done), I found these little things to be cleaned up / fixed. All minor and they still apply.

chu11 added some commits Mar 7, 2018

modules/kvs: Minor kvstxn test cleanup
Explicitly copy newroot reference into buffer instead of
passing the new newroot pointer around.
modules/kvs: Return error on ENOMEM chance
In kvstxn_mgr_merge_ready_transactions(), return -1 on a call to
zlist_push() if it returns an error.
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 8, 2018

Looks reasonable, will merge once travis is done.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 8, 2018

Coverage Status

Coverage increased (+0.01%) to 78.819% when pulling 4ccdeca on chu11:kvscleanup10 into 5dc1611 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #1353 into master will increase coverage by 0.01%.
The diff coverage is 60%.

@@            Coverage Diff            @@
##           master   #1353      +/-   ##
=========================================
+ Coverage   78.49%   78.5%   +0.01%     
=========================================
  Files         162     162              
  Lines       29739   29741       +2     
=========================================
+ Hits        23343   23349       +6     
+ Misses       6396    6392       -4
Impacted Files Coverage Δ
src/modules/kvs/kvstxn.c 78.65% <60%> (-0.33%) ⬇️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/broker/overlay.c 74.14% <0%> (-0.32%) ⬇️
src/common/libflux/message.c 81.48% <0%> (-0.24%) ⬇️
src/common/libflux/future.c 88.78% <0%> (+0.46%) ⬆️
src/common/libutil/dirwalk.c 94.28% <0%> (+0.71%) ⬆️
src/broker/modservice.c 80.58% <0%> (+0.97%) ⬆️
src/common/libkvs/kvs_watch.c 91.41% <0%> (+1.28%) ⬆️
src/modules/connector-local/local.c 74.38% <0%> (+1.43%) ⬆️

@garlick garlick merged commit 3eea25b into flux-framework:master Mar 8, 2018

3 of 4 checks passed

codecov/patch 60% of diff hit (target 78.49%)
Details
codecov/project 78.5% (+0.01%) compared to 5dc1611
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 78.819%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.