Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flux-wreck purge #1357

Merged
merged 3 commits into from Mar 15, 2018

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Mar 15, 2018

Fix typo/incorrect method call in flux wreck purge as noticed by @trws in #1356.

Also added a quick sanity of check of flux wreck purge in tests (don't know why this was never done!), and a few other runtime fixes I stumbled across during testing.

grondo added some commits Mar 15, 2018

wreck: fix flux-wreck purge
flux-wreck purge attempts to call the `commit` method on a flux
handle, the correct method is `kvs_commit`. Not sure how this
slipped by, but

Fixes #1356
t/t2000-wreck.t: add test for flux-wreck purge
Add a sanity check that flux-wreck purge works and can purge jobs.
cmd/flux-wreck: avoid runtime error with no jobs
Avoid a messy runtime error in various flux-wreck command when
there is no lwj. kvs directory yet.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 15, 2018

Coverage Status

Coverage increased (+0.02%) to 78.842% when pulling f4ba7fd on grondo:issue#1356 into e8056ed on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Mar 15, 2018

restarted failed build due to an instance of #1077. Actually accidentally restarted all builds, grrr.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #1357 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
+ Coverage   78.51%   78.55%   +0.04%     
==========================================
  Files         162      162              
  Lines       29741    29741              
==========================================
+ Hits        23350    23362      +12     
+ Misses       6391     6379      -12
Impacted Files Coverage Δ
src/common/libflux/ev_flux.c 97.56% <0%> (-2.44%) ⬇️
src/common/libflux/rpc.c 93.38% <0%> (-0.83%) ⬇️
src/connectors/local/local.c 87.4% <0%> (-0.75%) ⬇️
src/common/libflux/msg_handler.c 86.64% <0%> (-0.73%) ⬇️
src/broker/overlay.c 74.14% <0%> (-0.32%) ⬇️
src/common/libflux/reactor.c 93.44% <0%> (-0.29%) ⬇️
src/common/libflux/handle.c 83.66% <0%> (-0.25%) ⬇️
src/common/libflux/future.c 88.78% <0%> (ø) ⬆️
src/bindings/lua/lua-hostlist/hostlist.c 62.95% <0%> (+0.21%) ⬆️
src/common/libutil/base64.c 95.77% <0%> (+0.7%) ⬆️
... and 4 more
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 15, 2018

LGTM, thanks!

@garlick garlick merged commit 2f3a7a9 into flux-framework:master Mar 15, 2018

4 checks passed

codecov/patch Coverage not affected when comparing e8056ed...f4ba7fd
Details
codecov/project 78.55% (+0.04%) compared to e8056ed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 78.842%
Details

@grondo grondo deleted the grondo:issue#1356 branch Mar 19, 2018

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.