Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings/lua: fix clock_gettime workaround #1371

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Mar 19, 2018

The workaround for broken posix.clock_gettime legacy function in
luaposix 34 wasn't quite correct, and breaks on versions that
include a posix.time module, but don't include clock_gettime in
that module. This fix checks to ensure clock_gettime is actually
available before trying to use it.

bindings/lua: fix clock_gettime w/a on luaposix 31
The workaround for broken posix.clock_gettime legacy function in
luaposix 34 wasn't quite correct, and breaks on versions that
include a posix.time module, but don't include clock_gettime in
that module. This fix checks to ensure clock_gettime is actually
available before trying to use it.

Fixes #1370
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 19, 2018

Restarted a builder that appeared to hang in the cron tests.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 19, 2018

Restarted another builder that looks like it hung in t4000-issues-test, in the t0704-mpirun-rank.sh subtest.

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Mar 19, 2018

Restarted another builder that looks like it hung in t4000-issues-test, in the t0704-mpirun-rank.sh subtest.

Ugh, sorry! This is getting sad!

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage decreased (-0.06%) to 78.78% when pulling c85de69 on grondo:issue#1370 into a31d49c on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Mar 19, 2018

Thanks for the quick fix!

@garlick garlick merged commit 3fea0a0 into flux-framework:master Mar 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 78.78%
Details

@grondo grondo deleted the grondo:issue#1370 branch Mar 19, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 19, 2018

Codecov Report

Merging #1371 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1371      +/-   ##
==========================================
- Coverage   78.52%   78.46%   -0.06%     
==========================================
  Files         162      162              
  Lines       29741    29741              
==========================================
- Hits        23354    23337      -17     
- Misses       6387     6404      +17
Impacted Files Coverage Δ
src/modules/connector-local/local.c 72.74% <0%> (-1.64%) ⬇️
src/common/libflux/request.c 87.17% <0%> (-1.29%) ⬇️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/broker/modservice.c 79.61% <0%> (-0.98%) ⬇️
src/common/libutil/dirwalk.c 93.57% <0%> (-0.72%) ⬇️
src/common/libkvs/kvs_watch.c 90.98% <0%> (-0.43%) ⬇️
src/broker/overlay.c 74.14% <0%> (-0.32%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/common/libflux/message.c 81.25% <0%> (-0.12%) ⬇️
src/cmd/flux-event.c 68.81% <0%> (+1.07%) ⬆️

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.