Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsc: Make jsc_job_state2num public #1374

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
4 participants
@dongahn
Copy link
Contributor

dongahn commented Mar 20, 2018

Promote jsc_job_state2num () to be public as this convenience routine can help w/ writing test cases for schedulers.

This should have been public as it is paired with jsc_job_num2state () anyway.

jsc: Make jsc_job_state2num public
Promote jsc_job_state2num () to be public as this convenience
routine can help w/ writing test cases for schedulers.

This should have been public as it is paired with
jsc_job_num2state () anyway.
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Mar 20, 2018

This seems reasonable. @dongahn, I'll merge once Travis reports back for good measure. Then we can restart tests in your flux-sched PR.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 20, 2018

Coverage Status

Coverage decreased (-0.007%) to 78.81% when pulling 2357edb on dongahn:jsc_fix into 537f4fc on flux-framework:master.

@grondo grondo merged commit 53e4898 into flux-framework:master Mar 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 78.81%
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #1374 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
- Coverage    78.5%   78.49%   -0.01%     
==========================================
  Files         162      162              
  Lines       29741    29741              
==========================================
- Hits        23348    23346       -2     
- Misses       6393     6395       +2
Impacted Files Coverage Δ
src/common/libjsc/jstatctl.c 78.42% <100%> (ø) ⬆️
src/common/libflux/attr.c 90% <0%> (-2%) ⬇️
src/broker/modservice.c 79.61% <0%> (-0.98%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/common/libkvs/kvs_watch.c 90.98% <0%> (-0.43%) ⬇️
src/common/libflux/message.c 81.36% <0%> (-0.12%) ⬇️
src/common/libflux/rpc.c 94.21% <0%> (+0.82%) ⬆️
src/common/libflux/response.c 85.36% <0%> (+1.62%) ⬆️
src/common/libflux/keepalive.c 93.33% <0%> (+6.66%) ⬆️
@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Mar 20, 2018

Thanks @grondo for quick response! I will restart the test for my sched PR.

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.