Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kvs: Refactor prep work for namespace prefix support #1390
This PR does a lot of refactoring on the internal kvs lookup API. The two major accomplishments of this PR are:
Then of course there are tons of unit tests along the way.
@@ Coverage Diff @@ ## master #1390 +/- ## ========================================== + Coverage 78.49% 78.54% +0.04% ========================================== Files 162 162 Lines 29724 29778 +54 ========================================== + Hits 23332 23389 +57 + Misses 6392 6389 -3
I don't feel I'm qualified to comment on this PR, but since @garlick is out and to keep your work moving forward, I thought I'd take a quick look to see if this could be merged.
My only comments are that the
Otherwise, I would be happy to merge this now if you'd like. If there are other comments by @garlick later those could always be fixed up in a future PR.
Mar 28, 2018
Cool. OK @chu11 please keep in mind that maybe that some of the internal KVS API implementations might need a review/refactor pass. I hate to keep pushing for more features and not give the impression that taking the time to do that sort of thing isn't available. We should make time for it as we go.