Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
wreck incremental improvements #1399
This is a set of changes accumulated in wreck to support the splash app issue #1358. It still needs work and tests added, but features are functional, including:
Also thrown in (these should be pulled out probably):
The re-worked code to parse
It may be that this approach which uses the current method of scheduler resource assignment will work "good enough" to satisfy #1358, but we'll need to have @trws comment. The only thing that a full
Lastly, I have to apologize for the quality of work here. This is definitely a rush job. Given more time it would have been better to refactor wrexecd.c first, and possibly the job module is due for a rewrite as well to remove all synchronous RPCs.
referenced this pull request
Mar 29, 2018
@@ Coverage Diff @@ ## master #1399 +/- ## ========================================== - Coverage 78.52% 78.47% -0.05% ========================================== Files 162 163 +1 Lines 29768 29979 +211 ========================================== + Hits 23374 23526 +152 - Misses 6394 6453 +59
Ok, fixed up the typo in commit message. I've also added @trws changes to add an
We'll need @dongahn to fix up his pending PR in flux-sched to also pull ncores directly from the event, and perhaps point me in the right direction to add the ncores field to jsc.