Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: don't check namespace if user passes in at reference #1436

Merged
merged 4 commits into from Apr 7, 2018

Conversation

4 participants
@chu11
Copy link
Contributor

chu11 commented Apr 7, 2018

Fixes issue #1401, where on replays namespaces were always checked for validity even if user originally passed in at reference.

At unit tests appropriately.

chu11 added some commits Apr 4, 2018

modules/kvs: Fix error in namespace removed tests
Fix error in which a treeobj was created where a valref raw buffer
should have been created.
modules/kvs: Don't check namespace if root ref set
If the user passed in a root reference, there is no need to check
if the namespace the user passed in is valid.

Fixes #1401
modules/kvs: Add lookup at reference tests
Add tests to check for situations in which root reference is specified
by the user, and ensure namespace checks are not done.

@chu11 chu11 added this to To do in multi-user parallel jobs via automation Apr 7, 2018

@chu11 chu11 moved this from To do to In progress in multi-user parallel jobs Apr 7, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 7, 2018

Coverage Status

Coverage increased (+0.03%) to 79.05% when pulling 944fe4b on chu11:issue1401 into 7160a8d on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 7, 2018

Codecov Report

Merging #1436 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
+ Coverage   78.72%   78.74%   +0.02%     
==========================================
  Files         163      163              
  Lines       30204    30206       +2     
==========================================
+ Hits        23777    23787      +10     
+ Misses       6427     6419       -8
Impacted Files Coverage Δ
src/modules/kvs/lookup.c 82.3% <100%> (+0.06%) ⬆️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/common/libkvs/kvs_txn.c 74.71% <0%> (-0.57%) ⬇️
src/bindings/lua/flux-lua.c 81.06% <0%> (+0.08%) ⬆️
src/modules/kvs/kvs.c 66.14% <0%> (+0.16%) ⬆️
src/modules/connector-local/local.c 74.59% <0%> (+0.2%) ⬆️
src/cmd/flux-module.c 85.36% <0%> (+0.3%) ⬆️
src/broker/overlay.c 74.45% <0%> (+0.31%) ⬆️
src/common/libflux/message.c 81.48% <0%> (+0.47%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Apr 7, 2018

Seems reasonable, thanks,

@garlick garlick merged commit c3b3868 into flux-framework:master Apr 7, 2018

4 checks passed

codecov/patch 100% of diff hit (target 78.72%)
Details
codecov/project 78.74% (+0.02%) compared to 7160a8d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 79.05%
Details

multi-user parallel jobs automation moved this from In progress to Done Apr 7, 2018

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.