Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: Remove unnecessary/superfluous log messages #1440

Merged
merged 2 commits into from Apr 10, 2018

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Apr 9, 2018

Per discussion in #1433.

In addition, tweak some unit tests so they do not generate some confusing log messages.

@coveralls
Copy link

coveralls commented Apr 9, 2018

Coverage Status

Coverage increased (+0.02%) to 79.038% when pulling a316435 on chu11:issue1433 into 83861e2 on flux-framework:master.

@codecov-io
Copy link

codecov-io commented Apr 9, 2018

Codecov Report

Merging #1440 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
+ Coverage   78.71%   78.73%   +0.01%     
==========================================
  Files         163      163              
  Lines       30206    30203       -3     
==========================================
+ Hits        23778    23781       +3     
+ Misses       6428     6422       -6
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.81% <66.66%> (-0.17%) ⬇️
src/common/libflux/response.c 83.73% <0%> (-0.82%) ⬇️
src/common/libutil/dirwalk.c 94.28% <0%> (-0.72%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/common/libflux/handle.c 83.66% <0%> (-0.25%) ⬇️
src/bindings/lua/flux-lua.c 80.97% <0%> (-0.09%) ⬇️
src/common/libflux/message.c 81.6% <0%> (+0.47%) ⬆️
src/common/libkvs/kvs_txn.c 75.28% <0%> (+0.56%) ⬆️
src/modules/connector-local/local.c 74.38% <0%> (+1.43%) ⬆️

@chu11
Copy link
Member Author

chu11 commented Apr 10, 2018

diff target miss is only a single log message entry which is an "impossible" error

@garlick
Copy link
Member

garlick commented Apr 10, 2018

Good! Needs a rebase though.

Remove unnecessary logging of "normal" errors.

Fixes flux-framework#1433
Rename namespaces in namespace prefix tests so that they are
different than other tests.

Having similar prefixes lead to unnecessary log messages in
the tests that were confusing.
@chu11
Copy link
Member Author

chu11 commented Apr 10, 2018

rebased and pushed

@garlick garlick merged commit f4e0b7e into flux-framework:master Apr 10, 2018
@grondo grondo mentioned this pull request May 10, 2018
@chu11 chu11 deleted the issue1433 branch June 5, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants