Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: couple of minor fixes #1466

Merged
merged 2 commits into from Apr 16, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Apr 14, 2018

Add a few unit tests based on #1463 discussion.

Remove a log message per #1462.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 14, 2018

Coverage Status

Coverage decreased (-0.03%) to 78.992% when pulling c9c2d45 on chu11:issue1462 into 62100bf on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Apr 14, 2018

think i hit #1169 , restart builder

�[0;31mFAIL�[m: t2004-hydra.t 1 - Hydra runs hello world
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Apr 14, 2018

Looks fine, just needs a rebase.

chu11 added some commits Apr 13, 2018

modules/kvs: Add multiple operation unit tests
Add unit tests covering multiple transactions which all use the
same namespace prefix.
modules/kvs: Remove unnecessary log
Error is returned to user, so the log of an error is unnecessary.

Fixes #1462

@chu11 chu11 force-pushed the chu11:issue1462 branch from a0bc9ab to c9c2d45 Apr 16, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Apr 16, 2018

rebased

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Apr 16, 2018

restarted a builder that hung in the faketime test

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #1466 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
- Coverage   78.72%   78.69%   -0.04%     
==========================================
  Files         163      163              
  Lines       30265    30264       -1     
==========================================
- Hits        23826    23815      -11     
- Misses       6439     6449      +10
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.79% <ø> (-0.03%) ⬇️
src/common/libflux/ev_flux.c 97.56% <0%> (-2.44%) ⬇️
src/common/libflux/request.c 87.17% <0%> (-1.29%) ⬇️
src/connectors/local/local.c 87.4% <0%> (-0.75%) ⬇️
src/common/libflux/msg_handler.c 86.64% <0%> (-0.73%) ⬇️
src/common/libflux/handle.c 83.16% <0%> (-0.5%) ⬇️
src/broker/overlay.c 73.81% <0%> (-0.32%) ⬇️
src/cmd/flux-module.c 84.75% <0%> (-0.31%) ⬇️
src/common/libflux/reactor.c 93.44% <0%> (-0.29%) ⬇️
src/common/libflux/message.c 81.13% <0%> (-0.24%) ⬇️
... and 2 more

@garlick garlick merged commit c644b7f into flux-framework:master Apr 16, 2018

3 of 4 checks passed

codecov/project 78.69% (-0.04%) compared to 62100bf
Details
codecov/patch Coverage not affected when comparing 62100bf...c9c2d45
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 78.992%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.