Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/kvs: Enhance debug error messages #1477

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Apr 19, 2018

Add JSON_ENCODE_ANY in calls to json_dumps() to output additional
information on error/debug paths.

In addition, output pointer to original json object, to differentiate
between a NULL C pointer and the possible "null" json value.

modules/kvs: Enhance debug error messages
Add JSON_ENCODE_ANY in calls to json_dumps() to output additional
information on error/debug paths.

In addition, output pointer to original json object, to differentiate
between a NULL C pointer and the possible "null" json value.
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Apr 19, 2018

This is per discussion in #1467

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #1477 into master will increase coverage by 0.03%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
+ Coverage   78.71%   78.74%   +0.03%     
==========================================
  Files         164      164              
  Lines       30328    30328              
==========================================
+ Hits        23873    23883      +10     
+ Misses       6455     6445      -10
Impacted Files Coverage Δ
src/modules/kvs/kvstxn.c 79.15% <0%> (ø) ⬆️
src/modules/kvs/lookup.c 82.3% <33.33%> (ø) ⬆️
src/common/libflux/mrpc.c 85.49% <0%> (-1.18%) ⬇️
src/broker/modservice.c 80.58% <0%> (-0.98%) ⬇️
src/cmd/flux-module.c 84.75% <0%> (-0.31%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/common/libflux/handle.c 83.66% <0%> (ø) ⬆️
src/common/libflux/message.c 81.25% <0%> (+0.11%) ⬆️
src/broker/overlay.c 74.13% <0%> (+0.31%) ⬆️
src/common/libutil/base64.c 95.77% <0%> (+0.7%) ⬆️
... and 4 more
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Apr 19, 2018

Thanks!

@garlick garlick merged commit 7248668 into flux-framework:master Apr 19, 2018

3 of 4 checks passed

codecov/patch 20% of diff hit (target 78.71%)
Details
codecov/project 78.74% (+0.03%) compared to cb2f8db
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 79.05%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.